Post Types with numeric characters in the slug are not searchable within the nav menu

[kshaner]

When a post type is registered, the slug is run through sanitize_key.

The docblock for sanitize_key:

Keys are used as internal identifiers. Lowercase alphanumeric characters, dashes, and underscores are allowed.

When a post type is registered with a numeric character, the function _wp_ajax_menu_quick_search contains a regex that tries to match the post type from the request payload $_POSTtype? which contains a payload formatted like: quick-search-posttype-post or quick-search-posttype-page.

However when a numeric character is in the post type slug, the regex that validates the post type does not allow numeric characters.

The current call is:

preg_match( '/quick-search-(posttype|taxonomy)-([a-zA-Z_-]*\b)/', $type, $matches ) )

To match the allowed formats of sanitize_key, this regex should be modified to:

preg_match( '/quick-search-(posttype|taxonomy)-([a-zA-Z0-9_-]*\b)/', $type, $matches ) )

Trac ticket: https://core.trac.wordpress.org/ticket/63633

[oglekler]

This ticket needs a reproduction report and testing.

@mindctrl Unit test added! Confirmed the test failed against trunk and passed on this branch.

[mindctrl]

@kshaner nice find. I've tested your patch and confirmed it fixes the issue.

Here what I did:

• activated a non-block theme such as Twenty Twelve
• confirmed this is a bug in trunk with the classic menu editor
• registered a custom post type with the slug test_123
• created a new post of the test_123 type
• went to Appearance > Menus
• clicked Screen Options at top right and enabled the "Test 123" post type
• expanded the Test 123 panel in the menu editor
• clicked Search
• typed in some characters from the new post and saw the results

[westonruter]

In 60775:

Menus: Fix searchability of post types which contain numeric characters.

The regular expression needs to correspond to how a post type slug is sanitized by sanitize_key() in register_post_type().

Props kshaner, mindctrl, oglekler.
Fixes #63633.