WordPress.org
Get WordPress

Make WordPress Core

Opened 5 months ago

Closed 4 months ago

#63663 closed defect (bug) (fixed)

Improve documented return type for parsed blocks

Reported by: jeremyfelt's profile jeremyfelt Owned by: johnbillion's profile johnbillion
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: docs Cc:

Description

The blockName of a parsed block can be either a string or null. This should be clarified wherever these are documented to improve static analysis compatibility.

Previously, [58084], which likely contains all of the locations. :)

Change History (5)

#1 @yashjawale
5 months ago

Thanks for submitting the issue on trac!

I'll start working on a patch to resolve this...

This ticket was mentioned in ​PR #9187 on ​WordPress/wordpress-develop by ​@pmbaldha.
5 months ago #2

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/63663

​@mukesh27 commented on ​PR #9187:
4 months ago #3

Some issue it PHPCS that needs to fixed

#4 @johnbillion
4 months ago

  • Milestone changed from Awaiting Review to 6.9
  • Owner set to johnbillion
  • Status changed from new to reviewing

#5 @johnbillion
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 60511:

Docs: Improve the documented return type for parsed blocks.

The blockName property can be null, for example when a section of HTML outside of a block is encountered. This corrects the docs to reflect that.

Props jeremyfelt, pmbaldha, johnbillion.

Fixes #63663

Note: See TracTickets for help on using tickets.