Make WordPress Core

Opened 4 months ago

Closed 3 weeks ago

#63664 closed defect (bug) (fixed)

Twenty Nineteen & Twenty Twenty One: Add PHPDoc Block for the twentynineteen_content_width & twenty_twenty_one_content_width filter

Reported by: viralsampat's profile viralsampat Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: dev-feedback needs-testing has-patch
Focuses: docs Cc:

Description

Hello Team,

I reviewed the theme files and noticed the use of a PHPDoc block for the twentynineteen_content_width & twenty_twenty_one_content_width action hook in the Twenty Nineteen & Twenty Twenty One themes.

I think that it should be appropriate, as it helps with documentation and clarity.

Thanks,

Attachments (2)

twenty-nineteen-theme-63664.patch (1.0 KB) - added by viralsampat 4 months ago.
I have reviewed above mentioned issue and resolved it. Here, I have added its patch.
twenty-twenty-one-theme-63664.patch (1011 bytes) - added by viralsampat 4 months ago.
I have reviewed above mentioned issue and resolved it. Here, I have added its patch.

Download all attachments as: .zip

Change History (7)

@viralsampat
4 months ago

I have reviewed above mentioned issue and resolved it. Here, I have added its patch.

@viralsampat
4 months ago

I have reviewed above mentioned issue and resolved it. Here, I have added its patch.

This ticket was mentioned in PR #9188 on WordPress/wordpress-develop by @pmbaldha.


4 months ago
#1

  • Keywords has-patch added

#2 @SergeyBiryukov
3 weeks ago

  • Milestone changed from Awaiting Review to 6.9

#3 @SergeyBiryukov
3 weeks ago

In 61064:

Twenty Nineteen: Document the twentynineteen_content_width filter.

Includes removing an unnecessary PHPCS ignore annotation. The linked WPCS issue is not open anymore, and WordPress/WordPress-Coding-Standards#1773 indicates that the test now makes an exception for $content_width.

Follow-up to [43808].

Props viralsampat, pmbaldha, sabernhardt.
See #63664.

#4 @westonruter
3 weeks ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#5 @SergeyBiryukov
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 61070:

Twenty Twenty-One: Document the twenty_twenty_one_content_width filter.

Includes removing an unnecessary PHPCS ignore annotation. The linked WPCS issue is not open anymore, and WordPress/WordPress-Coding-Standards#1773 indicates that the test now makes an exception for $content_width.

Follow-up to [49216].

Props viralsampat, pmbaldha, sabernhardt.
Fixes #63664.

Note: See TracTickets for help on using tickets.