Bundled Theme: Add missing PHPDoc Block for the action.

[viralsampat]

Hello Team,

I reviewed the theme files and noticed the use of a PHPDoc block for the twentynineteen_scripts & twentyseventeen_scripts action hook in the Twenty Nineteen & Twenty Seventeen themes.

I think that it should be appropriate, as it helps with documentation and clarity.

Thanks,

[viralsampat]

I have reviewed above mentioned issue and resolved it. Here, I have added its patch.

[vladimiraus]

There is a difference between the function comment. Enqueues vs Enqueue: should make it consistent.

Theme consistency in php doc.

[vladimiraus]

Added merge request.

[mukesh27]

Thanks for the PR!

It looks good to me.

Move to 6.9

[SergeyBiryukov]

In 60494:

Twenty Seventeen: Add missing @since tag for twentyseventeen_scripts().

Follow-up to [38833].

Props viralsampat, vladimiraus, mukesh27.
See #63692.

[SergeyBiryukov]

In 60495:

Twenty Nineteen: Add missing @since tag for twentynineteen_scripts().

Follow-up to [43808].

Props viralsampat, vladimiraus, mukesh27.
Fixes #63692.

[mukesh27]

@SergeyBiryukov could you please commit changes for src/wp-content/themes/twentyfifteen/functions.php. The PR ​https://github.com/WordPress/wordpress-develop/pull/9294 have that changes.

[SergeyBiryukov]

Replying to mukesh27:

could you please commit changes for src/wp-content/themes/twentyfifteen/functions.php

I left that out for now, as those older themes are not super consistent with using third-person singular verbs in function descriptions, and there are at least 8 other instances of "Enqueue scripts" in other themes. So I think fixing just that one instance would not really add any consistency, see also twentyfifteen_block_editor_styles()​ for example.

Happy to reopen if someone is interested in updating all of those DocBlocks to use third-person singular verbs :)

[mukesh27]

@vladimiraus Can you open separate PR?

Third-person singular verbs update for themes.

[vladimiraus]

@SergeyBiryukov @mukesh27 PR is open.

[SergeyBiryukov]

In 60505:

Twenty Ten: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60506:

Twenty Eleven: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60507:

Bundled Themes: Revert some documentation changes to use third-person singular verbs.

These are inline comments, not function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Follow-up to [60505], [60506].

See #63692.

[SergeyBiryukov]

In 60508:

Twenty Twelve: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60509:

Twenty Ten: Use third-person singular verbs for some more function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Follow-up to [60505], [60507].

See #63692.

[SergeyBiryukov]

In 60513:

Twenty Eleven: Use third-person singular verbs for some more function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Follow-up to [60506], [60507].

See #63692.

[SergeyBiryukov]

In 60514:

Twenty Twelve: Use third-person singular verbs for some more function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Follow-up to [60508].

See #63692.

[SergeyBiryukov]

In 60515:

Twenty Thirteen: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60519:

Twenty Fourteen: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60521:

Twenty Fifteen: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60527:

Twenty Sixteen: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60533:

Twenty Seventeen: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60535:

Twenty Nineteen: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60536:

Twenty Twenty: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60537:

Twenty Twenty-One: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60538:

Twenty Twenty-Two: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

[SergeyBiryukov]

In 60610:

Twenty Twenty-Four: Use third-person singular verbs for function descriptions.

Reference: ​PHP Documentation Standards: Documenting Tips.

Props vladimiraus, mukesh27, SergeyBiryukov.
See #63692.

Thanks for the PR! Merged in r60505, r60506, r60508, r60515, r60519, r60521, r60527, r60533, r60535, r60536, r60537, r60538, and r60610.