Opened 5 months ago
Closed 5 months ago
#63704 closed defect (bug) (fixed)
Docs: Fix typo and mark unused parameter in deprecated functions
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.9 | Priority: | normal |
| Severity: | minor | Version: | |
| Component: | General | Keywords: | |
| Focuses: | docs | Cc: |
Description (last modified by )
This patch fixes a typo in the documentation comment for the get_udims() function in wp-admin/includes/deprecated.php ("Calculated" → "Calculates").
It also adds a comment to mark the unused $fp parameter in the debug_fclose() function in wp-includes/deprecated.php to avoid unused parameter warnings.
These are minor documentation/code quality improvements.
Attachments (2)
Change History (6)
#2
follow-up:
↓ 3
@
5 months ago
- Focuses docs added; coding-standards removed
- Keywords close 2nd-opinion added
- Severity changed from normal to minor
I think I prefer not to make any of these revisions, but I made a patch with only the first.
- "Calculated" could be worth changing to "Calculates", but three commits—while
get_udims()was still in use—did not fix that typo when they edited other parts of the same line.
(either r8912, r9119, or r18632) debug_fclose()already identifies that the$fpparameter is unused.* @param mixed $fp Unused.
- Adding an extra space in the
str_replaceparameters is not a good idea in a deprecated function. If matching'<img 'instead of'<img'somehow could prevent a problem, four (non-deprecated) functions inwp-includes/media.phpuse'<img'without the space.
Note: See
TracTickets for help on using
tickets.
Hi there!
Welcome to Trac, and thank you for creating the ticket.
Since those functions are deprecated, it doesn't make sense to update them at this point. I've marked the ticket for developer feedback to confirm whether we plan to update these files or leave them as is.