WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#6372 closed enhancement (duplicate)

Addition of ID's on some form elements in wp-includes/widgets.php

Reported by: diegomax Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.5
Component: Widgets Keywords: needs-patch
Focuses: Cc:

Description

Hello there WordPress developers.

I would like to suggest the addition of some ID tags to some form elements in the wp-includes/widgets.php file.

In line 414 the search widget "Submit" button lacks the ID tag.

<input type="submit" value="<?php echo attribute_escape(__('Search')); ?>" />

This little issue breaks compatibility with some specific css customizations with every upgrade and i think it should be trivial to fix.
Im aware of course that this could still be styled by using proper css inheritance, etc, but since every other element in the widgets file comes with proper ID's, I´m pretty sure that this is just a forgotten code bit.
Thanks in advance.
Diego.

Change History (4)

comment:1 Viper007Bond6 years ago

  • Component changed from General to Template
  • Keywords needs-patch added
  • Milestone changed from 2.3.4 to 2.6
  • Version changed from 2.3.3 to 2.5

comment:2 ionfish6 years ago

This issue is also addressed by #5567, which replaces the widget search form with the theme's search form (or if none is provided, the default theme's search form). This adds consistency and reduces code duplication.

comment:3 ryan5 years ago

  • Component changed from Template to Widgets
  • Owner anonymous deleted

comment:4 Denis-de-Bernardy5 years ago

  • Milestone 2.9 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

fixed in #5567

Note: See TracTickets for help on using tickets.