Opened 15 months ago
Closed 15 months ago
#63732 closed task (blessed) (fixed)
Observation on Unused Global Variables in WordPress Core PHP Files
| Reported by: | viralsampat | Owned by: | johnjamesjacoby |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.9 |
| Component: | General | Version: | 6.7 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | docs |
Description
Hello Team,
I have reviewed the WordPress core PHP files and noticed that some global variables are referenced in the comments but are not explicitly defined in the code itself.
So, I think that if these variables are not being used anywhere, they should be removed from the list to avoid confusion and keep the codebase clean.
Files:
wp-admin/includes/plugin.php
wp-includes/rss.php
wp-includes/update.php
Please review it and share your feedback.
Thanks,
Attachments (1)
Change History (5)
#1
@
15 months ago
- Keywords needs-testing dev-feedback 2nd-opinion removed
- Milestone Awaiting Review → 6.9
- Owner set to
- Status new → assigned
- Type defect (bug) → task (blessed)
Both wp-admin/includes/plugin.php and wp-includes/rss.php look OK to me.
wp-includes/update.php uses wp_get_wp_version() since r58813, so some references to the $wp_version global could be removed.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
I have checked above mentioned issue and resolved it. Here, I have added my patch.