General: Prevent php warning for not readable files

[Ninos Ego]

Having unreadable php-files in theme-directory triggers following php-warning:

file_get_contents(/path/to/thememaySubdir/file.php): Failed to open stream: No such file or directory in /wp-includes/class-wp-theme.php#L1333

This PR hardens the get_post_templates() function a bit.

Ref:
​https://github.com/WordPress/wordpress-develop/pull/9311

Having unreadable php-files in theme-directory triggers following php-warning:

file_get_contents(/path/to/thememaySubdir/file.php): Failed to open stream: No such file or directory in /wp-includes/class-wp-theme.php#L1333

This PR hardens the get_post_templates() function a bit.

Trac:
https://core.trac.wordpress.org/ticket/63743

How would site admins, or log monitoring tools, know when there's a file read error if we suppress errors?

How would site admins, or log monitoring tools, know when there's a file read error if we suppress errors?

For me such error output only makes sense for files which must be readable. The function parses all php-files in theme's subdirectories, not only template files, also which are not relevant for templating. Would be better to have some predefined folders (theme dir, /templates, ...) for parsing (also for performance reasons), but this would may break compatibility with some themes.

[krupajnanda]

Hi @ninos-ego

Thanks for the patch!

Could you share how this warning is triggered? What are scenarios/use-cases here? Additionally, if you could share steps along with some visual/screenshot will be helpful to validate the patch and its impact more accurately.

[jorbin]

Having an unreadable file in your theme feels more like a misconfiguration of a site than something that should be blindly ignored.

[mindctrl]

I agree with @jorbin here. I don't think it's wise to hide file read errors. Hiding errors from site admins and monitoring tools makes the problem harder to discover and debug. With that in mind, I'm going to close this ticket to help clean up Trac. Feel free to reopen if you think this is a problem that needs to be solved in a more visible way.