Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 5 months ago

#63762 closed enhancement (fixed)

Composer: update to WordPressCS 3.2.0

Reported by: rodrigosprimo's profile rodrigosprimo Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

WordPressCS 3.2.0 was released last week.

It is recommended for WP Core to update as soon as convenient. The impact on existing Core code is expected to be low to non-existent. The release updates some sniffs to account for changes in recent WordPress versions up to 6.8.

Refs:

https://github.com/WordPress/WordPress-Coding-Standards/releases/tag/3.2.0
https://github.com/WordPress/WordPress-Coding-Standards/compare/3.1.0...3.2.0

Previous: #60840

Props: @jrf, @dingo_d, @garyj, @rodrigosprimo, @westonruter, Dan Wallis, @szepeviktor, @jonmcpartland, @davidperez, @rockfire.

Change History (8)

This ticket was mentioned in PR #9339 on WordPress/wordpress-develop by @rodrigosprimo.


6 months ago
#1

  • Keywords has-patch added

#2 @rodrigosprimo
6 months ago

  • Keywords has-patch removed

I opted to update PHPCS to the latest version in the PR, as this was done in the previous ticket as well (#60840). The impact of this PHPCS on core code should be minimal to non-existent. Happy to revert this change if needed.

#3 @desrosj
6 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.9

#4 @mukesh27
6 months ago

  • Keywords commit added

Mark ready for commit

#5 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#6 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 60523:

Coding Standards: Upgrade WPCS to version 3.2.0.

The release updates some sniffs to account for changes in recent WordPress versions up to 6.8.

References:

Follow-up to [56695], [56799], [57378], [57986].

Props jrf, dingo_d, garyj, rodrigosprimo, westonruter, fredden, szepeviktor, jonmcpartland, davidperez, rockfire, desrosj, swissspidy, mukesh27, SergeyBiryukov.
Fixes #63762.

@sabernhardt commented on PR #9339:


5 months ago
#7

@fredden You received props for your contribution toward r60523 under your GitHub username, and I did not find a WordPress.org username for you.

Could you create a profile (if you have not done so already) and link it to your GitHub?
https://make.wordpress.org/core/handbook/tutorials/linking-your-github-and-w-org-profiles/

This ticket was mentioned in Slack in #core by rodrigoprimo. View the logs.


5 months ago

Note: See TracTickets for help on using tickets.