Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#63815 closed enhancement (fixed)

Re-encode non-UTF-8-compatible source files.

Reported by: dmsnell's profile dmsnell Owned by: dmsnell's profile dmsnell
Milestone: 6.9 Priority: normal
Severity: normal Version: 6.9
Component: General Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

A couple of files in the codebase contain invalid UTF-8. They are encoded as Windows-1252, and if they could be interpreted as such would not be problematic, but as they are, they will be interpreted as UTF-8.

These should be consistently UTF-8 and cleaned up where possible.

Change History (2)

This ticket was mentioned in PR #9425 on WordPress/wordpress-develop by @dmsnell.


6 months ago
#1

  • Keywords has-patch has-unit-tests added

Trac ticket: Core-63815

The files in this commit have previously contained text encoded as Windows-1252 (commonly mistaken for latin1/ISO-8859-1), in ways that present invalid UTF-8 bytes.

This commit converts the encodings to UTF-8, which resolves the encoding issues. While the whole-posts document could be argued to be intentionally Windows-1252, there was no obvious evidence that this was more than an historic legacy. The JavaScript file, however, definitely ought to be UTF-8.

#2 @dmsnell
6 months ago

  • Owner set to dmsnell
  • Resolution set to fixed
  • Status changed from new to closed

In 60627:

Convert two source files to UTF-8

The files in this commit have previously contained text encoded as Windows-1252 (commonly mistaken for latin1/ISO-8859-1), in ways that present invalid UTF-8 bytes.

This commit converts the encodings to UTF-8, which resolves the encoding issues. While the whole-posts document could be argued to be intentionally Windows-1252, there was no obvious evidence that this was more than an historic legacy. The JavaScript file, however, definitely ought to be UTF-8.

Developed in https://github.com/WordPress/wordpress-develop/pull/9425
Discussed in https://core.trac.wordpress.org/ticket/63815

Props dmsnell, swisspidy.
Fixes #63815.

Note: See TracTickets for help on using tickets.