Layout type classname incorrect for custom blocks

[peroks]

This bug has already been reported in the Gutenberg repository here: ​https://github.com/WordPress/gutenberg/issues/53295 and even fixed in this PR: ​https://github.com/WordPress/gutenberg/pull/53404

Unfortunately, the PHP fix was not ported back to WordPress core, so as of WP 6.8.2, the bug is still not fixed.

The bug is found here: ​https://github.com/WordPress/wordpress-develop/blob/6.8.2/src/wp-includes/block-supports/layout.php#L861

Current/buggy PHP code

<?php
$block_name    = explode( '/', $block['blockName'] );
$class_names[] = 'wp-block-' . end( $block_name ) . '-' . $layout_classname;

Fixed code in the Gutenberg repository

<?php
$split_block_name = explode( '/', $block['blockName'] );
$full_block_name  = 'core' === $split_block_name[0] ? end( $split_block_name ) : implode( '-', $split_block_name );
$class_names[]    = 'wp-block-' . $full_block_name . '-' . $layout_classname;

[rishabhwp]

Thank you for bringing this up. I’ll be happy to work on it and raise a PR.

[isabel_brison]

In 60651:

Editor: Include namespace in layout classname for non-core blocks.

Adds block namespace in layout classname so global styles can be built correctly.

Props isabel_brison, wildworks, peroks, rishabhwp.
Fixes #63844, #63839.

Closing this out as the change has been committed in https://core.trac.wordpress.org/changeset/60651.

@R1shabh-Gupta I see you added me as a reviewer but I didn't get notified because the PR is in draft mode. For next time, feel free to "create pull request" instead of "create draft" so reviewers can be notified! (Unless you're still working on it that is 😄)

Thanks for contributing!

[rishabhwp]

Hey @isabel_brison,
The PR was still a work in progress. I was in the middle of adding tests for it.
You can check ​https://github.com/WordPress/wordpress-develop/blob/trunk/tests/phpunit/tests/block-supports/layout.php, which contains all the tests for block supports. I think adding tests here would be really valuable in this case. The code is nearly ready. Would you prefer that I update the existing PR, or should I open a new one to include the tests?

[isabel_brison]

@rishabhwp might be easier to open a new one for the tests!

[rishabhwp]

Hi @isabel_brison,
I've added unit tests to ensure the fix works as expected. Could you please review the changes when you have a moment? Thank you!

[wildworks]

Hi @isabel_brison, do you have the bandwidth to review ​PR 9541?

If there is no activity on this ticket by next week's 6.9 RC1 release, I will punt it to 7.0.

Not sure why the tests are failing on CI; they pass for me locally.

[isabel_brison]

Thanks for the ping @wildworks! I've reviewed the PR. Happy to commit it unless you want to do so!

@tellthemachines, I merged the latest trunk branch into this branch. Hopefully, this will resolve the test failure.

@tellthemachines, it seems the CI failure has been fixed. If you have the bandwidth, please feel free to commit!

[isabel_brison]

In 61175:

Editor: update layout tests.

Adds a test for name spacing custom blocks in layout classnames.

Props rishabhwp, wildworks, isabel_brison.
Fixes #63839.

Done, thanks for the updates @t-hamano !