WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#6387 closed task (blessed) (fixed)

Duplicate post Tags UI for other taxonomies

Reported by: tellyworth Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: General Keywords: blessed
Focuses: Cc:

Description

This duplicates the Tags postbox UI (with the Add button and X to remove) for all non-hierarchical post taxonomies.

No doubt js experts will find it crude in spots but it works. I've left in two register_taxonomy() calls that I used for testing, lines 209 and 210 of edit-form-advanced.php. They're useful for testing this patch but should obviously be removed for production.

There's no real code for fetching or saving taxonomies other than post_tag. That should probably be included but requires some careful fitting with get_tags_to_edit() and friends so I've left it out for now. I added a quick filter as a crude fetch hook but it should probably be replaced with something more solid.

Attachments (9)

post-taxonomy-ui-r7493-2.patch (7.5 KB) - added by tellyworth 6 years ago.
post-taxonomy-ui-r7493-3.patch (10.0 KB) - added by tellyworth 6 years ago.
save and fetch code added
post-taxonomy-ui-r7521-3.patch (10.1 KB) - added by tellyworth 6 years ago.
fix conflicts and diff against 7521
post-taxonomy-ui-r7521-4.patch (13.4 KB) - added by tellyworth 6 years ago.
fix css, l10n, autosave, enter keypress
post-taxonomy-ui-r7641-6.patch (14.1 KB) - added by tellyworth 6 years ago.
Updated patch applies to trunk
post-taxonomy-ui-r8339-2.patch (17.1 KB) - added by tellyworth 6 years ago.
patch against r8339 plus improvements
taxonomies-ui.r10210.patch (20.0 KB) - added by noel 5 years ago.
post taxonomies ui patched against r10210
6387-r10220.patch (25.5 KB) - added by azaozz 5 years ago.
6387-r10221.diff (26.0 KB) - added by ryan 5 years ago.
Lose show_message(). Fix notices. Use generic terms funcs instead of passing tax to tag funcs.

Download all attachments as: .zip

Change History (21)

tellyworth6 years ago

save and fetch code added

comment:1 tellyworth6 years ago

The new patch has some better code for saving and fetching. Note that, while wp_insert_post() still supports the tags_input item for compatibility, the new UI code now passes in $_POSTtax_input? instead.

The temporary test taxonomies are still there but moved to the bottom of taxonomy.php.

tellyworth6 years ago

fix conflicts and diff against 7521

tellyworth6 years ago

fix css, l10n, autosave, enter keypress

comment:2 ryan6 years ago

Would love if the get and set of post terms dealt with IDs instead of names since we're in the code.

comment:3 ryan6 years ago

  • Milestone changed from 2.5 to 2.6

tellyworth6 years ago

Updated patch applies to trunk

comment:4 tellyworth6 years ago

Same patch as before, but applies cleanly to r7641.

comment:5 matt6 years ago

  • Keywords blessed added

tellyworth6 years ago

patch against r8339 plus improvements

comment:6 ryan6 years ago

  • Milestone changed from 2.9 to 2.7

comment:7 westi6 years ago

  • Milestone changed from 2.7 to 2.8

Feature freeze.. move to 2.8 for now.

noel5 years ago

post taxonomies ui patched against r10210

comment:8 ryan5 years ago

  • Type changed from enhancement to task (blessed)

azaozz5 years ago

comment:9 ryan5 years ago

Instead of passing a taxonomy arg to a tag function, we should just use the generic term function. That tag functions are convenience wrappers but if we're passing a taxonomy to them they are fairly pointless.

comment:10 ryan5 years ago

Not sure what the show_message() call is about. Seems it should be removed.

ryan5 years ago

Lose show_message(). Fix notices. Use generic terms funcs instead of passing tax to tag funcs.

comment:11 ryan5 years ago

(In [10222]) Allow muliple tag-like taxonomies in the post editor. see #6387

comment:12 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.