Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#63942 closed defect (bug) (fixed)

Plugin Dependencies: incorrect disabled "Deactivate" row action text when a network active plugin has active dependencies

Reported by: pbiron's profile pbiron Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.9 Priority: normal
Severity: normal Version: 6.5
Component: Plugins Keywords: has-patch has-test-info commit
Focuses: administration, multisite Cc:

Description

Starting in WP 6.5, when a plugin that has dependencies that are active and has active dependencies, the Deactivate row action is disabled.

However, when network active plugin has dependencies that are active, instead of having the Network Deactivate row action disabled, the text of that disabled row action says Deactivate instead of Network Deactivate.

PR coming shortly.

Attachments (4)

trac-63942.png (40.9 KB) - added by pbiron 8 months ago.
trac-63942-after-patch.png (41.4 KB) - added by pbiron 8 months ago.
Row action text after patch applied
before-patch.png (69.4 KB) - added by shailu25 8 months ago.
Before Patch
after-patch.png (84.6 KB) - added by shailu25 8 months ago.
After Patch

Download all attachments as: .zip

Change History (11)

@pbiron
8 months ago

This ticket was mentioned in PR #9774 on WordPress/wordpress-develop by @pbiron.


8 months ago
#1

  • Keywords has-patch added

Fixes #63942

@pbiron
8 months ago

Row action text after patch applied

#2 @davidbaumwald
8 months ago

  • Owner set to davidbaumwald
  • Status changed from new to reviewing

#3 @davidbaumwald
8 months ago

  • Milestone changed from Awaiting Review to 6.9

#4 @nikunj8866
8 months ago

  • Keywords has-test-info added

Test Report

Description

✅ This report validates that the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/9774

Environment

  • WordPress: 6.8.2
  • PHP: 8.4.10
  • Server: nginx/1.26.1
  • Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.4.10)
  • Browser: Chrome 140.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Sixteen 3.6
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0
    • WPGetAPI 2.2.10
    • WPGetAPI API to Posts 1.3.18

Actual Results

  1. ✅ Issue resolved with patch.

Before Patch: https://prnt.sc/uKi6uiktga2f
After Patch: https://prnt.sc/-qh6sZxO1BA2

#5 @shailu25
8 months ago

Test Report

This Report Validates that the indicated patch addresses the issue.

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/9774

Environment:

WordPress - 6.8.2
OS - Windows
Browser - Chrome
Theme: Twenty Twenty Four
PHP - 8.2.27

Active Plugins:

  • Contact Form 7
  • Conditional Fields for Contact Form 7

Actual Results:

  • Issue Resolved with Patch ✅

Supplemental Artifacts

  • Attached Screenshots

@shailu25
8 months ago

Before Patch

@shailu25
8 months ago

After Patch

#6 @johnjamesjacoby
8 months ago

  • Keywords commit added

Looks good to me 👍

#7 @davidbaumwald
8 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 60723:

Plugins: Correct deactivate row action text when network active.

Specifically, this change when a network activated plugin has plugin dependencies, the disabled deactivate row action link text is changed from "Deactivate" to "Network Deactivate".

Follow-up to [57545].

Props pbiron, nikunj8866, shailu25, jjj.
Fixes #63942.

Note: See TracTickets for help on using tickets.