Tabbing through database upgrade screen shows "WordPress" text over logo

[johnbillion]

When the "Database Update Required" screen is shown, tabbing through it reveals the word WordPress partially overlaying the W logo.

To reproduce

• Trigger a database upgrade, for example by manually reducing the value of the db_version and initial_db_version options
• Visit wp-admin, you'll be redirected to wp-admin/upgrade.php
• Press tab and observe that when the W logo receives focus, the word WordPress partially overlays the logo
• Observe that the overlay doesn't disappear once focus moves elsewhere

I reproduced this on a site running 6.4 but it may have existed prior to that. Or it's caused by a change in browser behaviour.

Tested in Chrome/Chromium 139 and 140.

[johnbillion]

Screenshot

[sabernhardt]

removes links from logos on upgrade.php and maint/repair.php, and removes entire 'logo' paragraph when install.php is accessed without PHP running

[sabernhardt]

Chrome apparently does not like hiding an interactive element with text-indent, which is probably a good thing. The browser behavior for these links might have changed since 2020, but I can reproduce it back to WordPress 5.5.

#47759 removed the link from the install.php and setup-config.php screens. I would prefer to remove the similar links from additional pages that use the install stylesheet.

• wp-admin/upgrade.php
• wp-admin/maint/repair.php
• wp-admin/install.php: Where it checks whether PHP is running, the page would not have a stylesheet, and I think the entire paragraph could be removed. Or if the link is worth keeping there, simply removing the id could help to avoid confusion.

(Another option I considered was to set the link to display: block with width and height at 100%, but then Chrome would only show a box-shadow on the bottom and Firefox would not show any focus indicator.)

[joedolson]

Because the links are set offscreen using text-indent, they're not clickable using a mouse, so the majority of users are not going to miss anything by removing these.

I also agree that since there is no CSS when PHP isn't running, there's no reason to output something that requires it. It would be nice to have a help link to point people to, but from a practical standpoint, I'm not sure there's anything we can say. This is a place where people will just need to contact their host.

Looking at the practical outcomes here, I don't see any reason not to go with these as they are.

Testing changes from 63950

Trac ticket: https://core.trac.wordpress.org/ticket/63950

[joedolson]

In 60898:

Upgrade/Install: WordPress text shows over logo on tab.

On the upgrade and repair screens, the logo link to wordpress.org was hidden using negative text-indent. This method makes the link impossible to click on using a mouse, and causes the text to overlay the image on keyboard focus.

On the install screen, if PHP is not running, the styles are not applied, leaving an unstyled link.

Remove the links for consistency with other screens following r47745.

Props johnbillion, sabernhardt, joedolson.
Fixes #63950.