Make WordPress Core

Opened 4 months ago

Closed 2 months ago

#63964 closed defect (bug) (fixed)

Twenty Twenty-Five: Rendering issues in Fira Sans font (requires update)

Reported by: jonsurrell's profile jonsurrell Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The Fira Sans font included with twentytwentyfive is older and has some issues that are fixed in recent releases. The font does not reserve space for the backtick "`" character, so it overlaps the following character.

Backticks are often used to delimit inline code or a code block and it's especially distracting when they're not positioned correctly or stack so the number of backticks is unclear.

I've tested the latest Fira Sans release and it does not have this issue.

#63963 describes the same issue with twentyfifteen and Noto font.

Attachments (6)

fira-editor.png (46.1 KB) - added by jonsurrell 4 months ago.
Backticks issue in the editor
fira-front.png (49.6 KB) - added by jonsurrell 4 months ago.
Backticks issue on the frontend
before-editor.png (53.3 KB) - added by lakshyajeet 4 months ago.
Before the fix: Editor
before-frontend.png (53.9 KB) - added by lakshyajeet 4 months ago.
Before the fix: Frontend
after-editor.png (57.4 KB) - added by lakshyajeet 4 months ago.
After the fix: Editor
after-frontend.png (43.1 KB) - added by lakshyajeet 4 months ago.
After the fix: Frontend

Download all attachments as: .zip

Change History (12)

@jonsurrell
4 months ago

Backticks issue in the editor

@jonsurrell
4 months ago

Backticks issue on the frontend

This ticket was mentioned in Slack in #themes by jonsurrell. View the logs.


4 months ago

#2 @sabernhardt
4 months ago

  • Summary changed from Twenty Twentyfive: Rendering issues in Fira Sans font (requires update) to Twenty Twenty-Five: Rendering issues in Fira Sans font (requires update)

This ticket was mentioned in PR #9886 on WordPress/wordpress-develop by @lakshyajeet.


4 months ago
#3

  • Keywords has-patch added

#4 @lakshyajeet
4 months ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.29
  • Server: nginx/1.29.0
  • Database: mysqli (Server: 8.4.6 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 138.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.3
  • MU Plugins: None activated
  • Plugins:

Actual Results

  1. ✅ Error condition occurs in both editor and frontend.

Additional Notes

  • Triple backticks (```) will be converted to a single backtick character (“`) on the frontend. This is expected behavior.

I was able to reproduce the issue and raised a PR for the same here https://github.com/WordPress/wordpress-develop/pull/9886

The PR updates Fira Sans font version for the Twenty Twenty-Five theme style from version 4.203 to version 4.301

Code used to test:

<!-- wp:paragraph -->
<p>Surrounded by: `backticks`. ``` 3 backticks precedes this sentence.</p>
<!-- /wp:paragraph -->

<!-- wp:code -->
<pre class="wp-block-code"><code>Surrounded by: `backticks`. ``` 3 backticks precedes this sentence.</code></pre>
<!-- /wp:code -->

@lakshyajeet
4 months ago

Before the fix: Editor

@lakshyajeet
4 months ago

Before the fix: Frontend

@lakshyajeet
4 months ago

After the fix: Editor

@lakshyajeet
4 months ago

After the fix: Frontend

#5 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 7.0

#6 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 61267:

Twenty Twenty-Five: Update Fira Sans font for the theme from version 4.203 to 4.301.

This aims to resolve rendering issues with the backtick character.

Follow-up to [59146].

Props lakshyajeet, jonsurrell.
Fixes #63964.

Note: See TracTickets for help on using tickets.