Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 8 months ago

#63983 closed defect (bug) (fixed)

wordpress-importer tests failing for old branches on PHP < 7.2

Reported by: desrosj Owned by:
Priority: normal Milestone: 6.9
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description (last modified by desrosj)

The WordPress Importer plugin has raised the minimum required version of PHP to 7.2 as of September 5, 2025 (see the PR on GitHub).

This has caused the PHPUnit tests to fail when running on older versions of PHP.

The Importer tests were removed from wordpress-develop in #42668/[59769].

The test workflow either needs a new boolean input to control whether these tests run, or the importer tests should be disabled entirely in older branches supporting PHP 7.1 and earlier.

Change History (29)

#1 @desrosj
10 months ago

  • Description modified (diff)

#2 follow-up: @swissspidy
10 months ago

Can we simply use an older version of the plugin on these branches?

This ticket was mentioned in PR #9894 on WordPress/wordpress-develop by @desrosj.


10 months ago
#3

  • Keywords has-patch added; needs-patch removed

This fixes the failing WordPress Importer plugin tests by pinning the final version of the plugin with support for PHP < 7.2.

Trac ticket: Core-63983

@desrosj commented on PR #9894:


10 months ago
#4

@swissspidy I've made the version dynamic so that the primary branch continues to be tested on 7.2+. Could you give it another look over for me?

#5 in reply to: ↑ 2 @desrosj
10 months ago

Replying to swissspidy:

Can we simply use an older version of the plugin on these branches?

Yes, that should work. The PR I've attached will dynamically checkout the correct version.

This ticket was mentioned in PR #9895 on WordPress/wordpress-develop by @desrosj.


10 months ago
#6

This fixes the failing WordPress Importer plugin tests by pinning the final version of the plugin with support for PHP < 7.2.

Trac ticket: Core-63983

@desrosj commented on PR #9894:


10 months ago
#7

Also created #9895 for the 6.5 branch, which is the latest branch with support for PHP < 7.2.

This ticket was mentioned in PR #9899 on WordPress/wordpress-develop by @desrosj.


10 months ago
#8

This fixes the failing WordPress Importer plugin tests by pinning the final version of the plugin with support for PHP < 7.2.

Trac ticket: Core-63983

#9 @desrosj
10 months ago

In 60748:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Props @swissspidy.
See #63983.

@desrosj commented on PR #9895:


10 months ago
#10

Fixed in r60748.

#11 @desrosj
10 months ago

In 60750:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 6.4 branch.

Props @swissspidy.
See #63983.

#12 @desrosj
10 months ago

In 60751:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 6.3 branch.

Props @swissspidy.
See #63983.

#13 @desrosj
10 months ago

In 60752:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 6.2 branch.

Props @swissspidy.
See #63983.

#14 @desrosj
10 months ago

In 60753:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 6.1 branch.

Props @swissspidy.
See #63983.

#15 @desrosj
10 months ago

In 60754:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 6.0 branch.

Props @swissspidy.
See #63983.

#16 @desrosj
10 months ago

In 60755:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.9 branch.

Props @swissspidy.
See #63983.

#17 @desrosj
10 months ago

In 60756:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.8 branch.

Props @swissspidy.
See #63983.

#18 @desrosj
10 months ago

In 60757:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.7 branch.

Props @swissspidy.
See #63983.

#19 @desrosj
10 months ago

In 60758:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.6 branch.

Props @swissspidy.
See #63983.

#20 @desrosj
10 months ago

In 60759:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.5 branch.

Props @swissspidy.
See #63983.

#21 @desrosj
10 months ago

In 60760:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.4 branch.

Props @swissspidy.
See #63983.

#22 @desrosj
10 months ago

In 60761:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.3 branch.

Props @swissspidy.
See #63983.

#23 @desrosj
10 months ago

In 60762:

Build/Test Tools: Pin Importer plugin version for PHP < 7.2.

The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead.

[59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite.

This change modifies the env:install script to download version 0.9.0 of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested.

Merges [60748] to the 5.2 branch.

Props @swissspidy.
See #63983.

#24 @desrosj
10 months ago

  • Milestone 6.96.8.3
  • Resolutionfixed
  • Status newclosed

@desrosj commented on PR #9894:


10 months ago
#25

Merged in r60762.

@desrosj commented on PR #9899:


10 months ago
#26

Fixed in r60751.

#27 @jorbin
10 months ago

  • Milestone 6.8.36.8.4

6.8.3 was a security only release. Punting though 6.8.4 is not planned as a release

#28 @desrosj
8 months ago

  • Milestone 6.8.46.9

With 6.9 RC1 out, there are no plans to ship a 6.8.4 release. Moving this to the 6.9 milestone as that will be the first release following the commits for this ticket.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


8 months ago

Note: See TracTickets for help on using tickets.