Site icon: Don't force cropping

[jorbin]

Do not force users to go through the cropping flow if the image is the correct ratio. This was fixed in the customizer in r59197, but that change needs to be ported to the site-options form of the site icon.

Trac ticket: #64020

[gulamdastgir04]

I have tested the patch in the playground using a 512x512 pixel square image as the site icon. When added through the Site Icon option, it successfully bypasses the image cropping flow.

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/10179.diff

Environment

• WordPress: 6.9-alpha-20251007.105636
• PHP: 8.3.25-dev
• Server: PHP.wasm
• Database: WP_SQLite_Driver (Server: 5.5 / Client: 3.40.1)
• Browser: Chrome 141.0.0.0
• OS: Linux
• Theme: Twenty Twenty-Five 1.3
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

✅ Issue resolved with patch.

[kirasong]

screencast - customizer as currently in trunk

[kirasong]

screencast - settings as currently in trunk

[kirasong]

screencast - settings after applying 10179.diff

[kirasong]

I tested the patch, and it does skip the cropping step, but the behavior is different than in the customizer, since it doesn't present the "skip cropping" button -- but instead assumes the user would like to skip.

As a user, I prefer this behavior, but it is a departure from the behavior in the customizer.

I've attached a before and after for customizer and settings.

Customizer Before: customizer - before .mov​
Settings Before: settings - before.mov​
Settings After applying ​10189.diff: settings - after.mov​

[gulamdastgir04]

@kirasong I agree - skipping the cropping step automatically feels like a smoother and more intuitive experience, even though it differs slightly from the Customizer flow. Having to crop an image that’s already the perfect size can be a real headache for users, so this behavior is definitely a welcome improvement.

[gulamdastgir04]

This improvement definitely deserves to be included in the 6.9 release. It feels user-friendly and aligns well with the current UX direction.

[jorbin]

The behavior should be consistent with the customizer. Just because something is square when uploaded doesn't mean that the site admin intends to use that exact square as the site icon.

[wildworks]

It seems we haven't yet reached an agreement on whether to proceed with ​PR 10179. Since the RC1 release is next week, I'd like to punt it to 7.0.

If an agreement is reached on the approach, please revert the milestone back to 6.9, and feel free to move forward.

[ozgursar]

Patch Testing Report

Patch Tested: ​https://github.com/WordPress/wordpress-develop/pull/10179

Environment

• WordPress: 7.0-alpha-61215-src
• PHP: 8.2.29
• Server: nginx/1.29.4
• Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
• Browser: Chrome 145.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.4
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.1

Steps taken

1. Activate any classic theme
2. Appearance > Customize > Site Identity
3. Click Select Site Icon
4. Upload a square png image that is equal or larger than 512x512 pixels
5. View Skip Cropping and Crop Image buttons
6. Activate Twenty Twenty-Five theme
7. Settings > General Settings > Site Icon
8. Click Choose a Site Icon
9. Upload a square png image that is equal or larger than 512x512 pixels
10. Click Set Site Icon
11. View only Crop Image button appears
12. Apply patch and repeat steps 7-10
13. Confirm that Crop Image button does not appear and directly sets the site icon
14. ✅ Patch is solving the problem

Expected result

• After applying the patch, if the image size is properly sized it won't ask for cropping the image.

Additional Notes

• Even though the experience is slightly different than Customize, I think it's better to skip the question Skip Cropping or Crop Image as the aspect ratio will stay the same.

Screenshots/Screencast with results

Video Customize (before patch): ​https://files.catbox.moe/reugxl.mp4
Video General Settings (before patch): ​https://files.catbox.moe/yz8qqc.mp4
Video General Settings (after patch): ​https://files.catbox.moe/0j67pe.mp4

[joedolson]

I agree with @jorbin; "square" does not mean it's the best option for the site icon.

[audrasjb]

As per today's 7.0 pre-RC1 bug scrub:

Given the PR makes the assumption that "square" equals "what I want for the site icon", some changes were requested in the current PR.
Moving to Future Release. Props @joedolson.