Make WordPress Core

Opened 14 months ago

Last modified 2 weeks ago

#64024 new defect (bug)

wp_die() status code Plugins component updates (parent ticket: #64009)

Reported by: callumbw95 Owned by:
Priority: normal Milestone: Awaiting Review
Component: Plugins Version:
Severity: normal Keywords: has-patch needs-test-info needs-testing
Cc: Focuses:

Description

If you have come here directly, please refer back to the parent ticket here: #64009

This ticket is regarding the wp_die() function calls within the Media component and will cover the following locations. Please note links were correct at the time of testing and writing this up, but line numbers may have changed slightly:

Filepath Line Number Context Status Code New Code Code Meaning
src/wp-admin/includes/plugin-install.php ​538 Error: is_wp_error( plugins_api() ;) 500 503 Service Unavailable
src/wp-admin/plugin-editor.php ​18 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugin-editor.php ​121 Missing: file 500 404 Not found
src/wp-admin/plugin-editor.php ​128 Error: invalid file type 500 415 Unsupported Media Type
src/wp-admin/plugins.php ​13 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​50 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​94 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​178 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​201 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​228 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​271 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​451 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​469 User Permissions: does not have access 500 403 Forbidden
src/wp-admin/plugins.php ​473 Error: is multisite, wrong admin 500 404 Not found
src/wp-admin/plugin-install.php ​19 User Permissions: does not have access 500 403 Forbidden

There are however the following function calls I have not touched as I felt they were already valid with their current status code:

Filepath Line Number Status Code
src/wp-admin/plugins.php ​67 500
src/wp-admin/plugins.php ​185 500
src/wp-admin/plugins.php ​459 500
src/wp-admin/plugins.php ​473 500

Change History (8)

This ticket was mentioned in ​PR #9996 on ​WordPress/wordpress-develop by ​@callumbw95.


14 months ago
#1

  • Keywords has-patch added

…s related to the plugins component

Trac ticket: #64024

#2 @nikunj8866
14 months ago

  • Keywords changes-requested added

@callumbw95 I've added a comment regarding a minor adjustment in the PR.

​@nikunj8866 commented on ​PR #9996:


14 months ago
#3

@CallumBW95 Could you please sync the latest wordpress-develop and then merge trunk into this branch? That might help resolve the PHPUnit test checks.

#4 @nikunj8866
14 months ago

  • Keywords changes-requested removed

#5 @nikunj8866
13 months ago

  • Keywords needs-testing needs-test-info added

#6 @desrosj
12 months ago

  • Version trunk

#7 @huzaifaalmesbah
2 weeks ago

  • Keywords needs-refresh added; needs-testing removed
Last edited 2 weeks ago by huzaifaalmesbah (previous) (diff)

#8 @huzaifaalmesbah
2 weeks ago

  • Keywords needs-testing added; needs-refresh removed

Apologies, my previous comment was intended for #42670. Restoring keywords here.

Note: See TracTickets for help on using tickets.