Opened 13 months ago
Closed 12 months ago
#64041 closed defect (bug) (fixed)
Twenty Twelve: support Image block rounded style
| Reported by: | lancewillett | Owned by: | joedolson |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.9 |
| Component: | Bundled Theme | Version: | 6.6 |
| Severity: | normal | Keywords: | has-patch has-screenshots commit |
| Cc: | Focuses: | css |
Description
Steps to reproduce
- Activate Twenty Twelve version 4.6
- Create a new post
- Add an "Image" block
- Upload an image
- In block settings, select "Rounded" under "Styles"
What I expected
For the rounded styles to apply both in the editor and on the front-end of the site.
What happened instead
Editor, yes. Front-end, no. Front-end shows square (default) styles.
Attachments (6)
Change History (17)
This ticket was mentioned in Slack in #themes by lancewillett. View the logs.
13 months ago
This ticket was mentioned in PR #10042 on WordPress/wordpress-develop by @dhruvang21.
13 months ago
#2
#3
@
13 months ago
- Component Themes → Bundled Theme
- Focuses css added
- Milestone Awaiting Review → 6.9
- Priority low → normal
- Severity minor → normal
- Version trunk → 6.6
The Rounded style had worked with WordPress 6.5, when the block-library stylesheet included
.wp-block-image .is-style-rounded img,
.wp-block-image.is-style-rounded img {
border-radius: 9999px;
}
6.6 reduced the specificity to
:root :where(.wp-block-image.is-style-rounded img, .wp-block-image .is-style-rounded img) {
border-radius: 9999px;
}
which is lower than img styles in Twenty Twelve's style.css:
.entry-content img,
.widget img {
border-radius: 3px;
}
64041.1.diff copies the pixel-value radius ruleset from the older block-library styles to the theme, and block-related styles belong in blocks.css.
#4
@
13 months ago
The 64041.1.diff working fine in my testing. See attached screenshot.
@mukesh27 commented on PR #10042:
13 months ago
#6
Thanks @dhruvang21.
The approach taken in https://core.trac.wordpress.org/attachment/ticket/64041/64041.1.diff is more appropriate then your so i'm going to close these PR.
#7
@
13 months ago
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/64041/64041.1.diff
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.29
- Server: nginx/1.29.1
- Database: mysqli (Server: 8.4.6 / Client: mysqlnd 8.2.29)
- Browser: Chrome 140.0.0.0
- OS: Linux
- Theme: Twenty Twelve 4.6
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Actual Results
- ✅ Issue resolved with patch.
Additional Notes
- Switch your theme to Twenty Twelve 4.6.
- Create a brand-new post.
- Insert an Image block.
- Upload any image to the block.
- In the block settings sidebar, choose the Rounded style under Styles.
Supplemental Artifacts
Before patch:
After patch:
#8
@
13 months ago
Test Report
This Report Validates that the indicated patch address the issue.✅
Patch Tested: https://core.trac.wordpress.org/attachment/ticket/64041/64041.1.diff
Environment:
WordPress - 6.8.3
OS - Windows
Browser - Chrome
Theme: Twenty Twelve
PHP - 8.2.27
Plugin - None
Actual Results:
- Issue Resolved with Patch ✅
Supplemental Artifacts
- Backend: https://prnt.sc/lup5KD-zUgRF
- Frontend Before Patch: https://prnt.sc/J1jGG5Wb8CUA
- Frontend After Patch: https://prnt.sc/air0zfePR_Sy
@dhruvang21 commented on PR #10042:
13 months ago
#9
@mukeshpanchal27 can you reopen this PR as i could update the code with latest patch or should create a new PR?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)



adds
border-radiusfrom WordPress 6.5block-librarystyles in Twenty Twelve'sblocks.css