When deleting users without any links/posts, don't ask to whom they should be reattributed

[markjaquith]

When deleting a user, it asks to whom their links/posts should be reattributed (or if they should be deleted). We can skip this screen if they don't have any links or posts.

[rajnikmit]

Hi,
I added a patch.Please check it and let me know.

[nacin]

Please create a diff against trunk. That patch removes a significant amount of code that was recently committed, and therefore I have no idea what you changed.

Please review your diffs pre/post upload. It would have been rather obvious to realize that you were suggesting so many changes.

[wojtek.szkutnik]

The previous one seems a little inefficient, this one should do a better job.

[MichaelZed]

See also ticket #23224 Delete Users: selecting a username should select the “Attribute all posts to” radio button

[ocean90]

#23730 was marked as a duplicate.

[benjmay]

I put a quick proof of concept together, essentially checking that any of the user(s) about to be deleted have any kind of post, and if they don't, just show a hidden input to run the default delete action on the next step, rather than re-assign.

I also put a check on the jQuery in the header, that if that hidden field exists, it doesn't disable the submit button.

I'm not sure if a text line with words to the effect of "This user has no posts that need to be dealt with" - incase they are expecting those two options.

[sethshoultes]

I tested the patch, submitted by benjmay, against trunk. I was able to delete a user, that didn't have any posts, without having to attribute (or delete) the non-existent posts to another user. I also tested with a user that had created a post, and was asked to attribute the post created by this user, to another user without issue.

It seems to be working pretty well.

[ocean90]

Version field indicates when the enhancement was initially suggested.

[benjmay]

Updated to work with changes in 4.3

[benjmay]

Thanks @chriscct7

Tested against both a single and multiple user with posts and without posts.

Come copy changes have been introduced since previous patch was submitted.

[chriscct7]

Looks good. There's a couple formatting issues with the ticket, and a general patch file issue, but I'll take care of them. Thanks for your work on this @benjmay!

[benjmay]

Ah, on reflection, I can see the tabbing/spacing is wrong. Thanks for taking care of it @chriscct7 :-)

[chriscct7]

Not a problem :)

[wonderboymusic]

Added Viz/Recs

In 6405.3.diff​:

• Move the JS function declaration to wp-admin/includes/user.php
• Rather than changing the JS to not run when there are no posts, don't include it at all if there are no posts

[wonderboymusic]

In 34000:

When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts.

Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405.