WordPress.org
Get WordPress

Make WordPress Core

Opened 12 months ago

Closed 12 months ago

#64050 closed defect (bug) (fixed)

PHP 8.5: Changed mime type for HEIF test image

Reported by: swissspidy Owned by: swissspidy
Priority: normal Milestone: 6.9
Component: Media Version:
Severity: normal Keywords: has-patch php85 has-unit-tests
Cc: Focuses: php-compatibility

Description

Parent ticket for all things PHP 8.5: #63061

In PHP 8.5, the following test fails:

1) Tests_Functions::test_wp_get_image_mime with data set #13 ('/var/www/tests/phpunit/includ...e.heic', 'image/heic')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'image/heic'
+'image/heif'

So the detected mime type is different now.

Change History (2)

This ticket was mentioned in ​PR #10079 on ​WordPress/wordpress-develop by ​@swissspidy.
12 months ago #1

  • Keywords has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/64050

#2 @swissspidy
12 months ago

  • Owner set to swissspidy
  • Resolution → fixed
  • Status assigned → closed

In 60810:

Media: Fix HEIF mime type assertion in test for PHP 8.5.

In PHP 8.5, the test image's mime type is now detected as image/heif, not image/heic.

Props swissspidy, adamsilverstein.
Fixes #64050.

Note: See TracTickets for help on using tickets.