Opened 5 months ago
Closed 3 months ago
#64069 closed task (blessed) (fixed)
Bump default theme versions for WordPress 6.9
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.9 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed fixed-major |
| Focuses: | Cc: |
Change History (27)
This ticket was mentioned in PR #10493 on WordPress/wordpress-develop by @shailu25.
4 months ago
#3
- Keywords has-patch added
Twenty Ten: 4.5
Twenty Eleven: 5.0
Twenty Twelve: 4.7
Twenty Thirteen: 4.5
Twenty Fourteen: 4.4
Twenty Fifteen: 4.1
Twenty Sixteen: 3.7
Twenty Seventeen: 4.0
Twenty Nineteen: 3.2
Twenty Twenty: 3.0
Twenty Twenty-One: 2.7
Twenty Twenty-Two: 2.1
Twenty Twenty-Three: 1.7
Twenty Twenty-Four: 1.4
Twenty Twenty-Five: 1.4
Trac ticket: #60999
@sabernhardt commented on PR #10493:
4 months ago
#4
I'm not ready to do a thorough review, but I have two comments.
- r60934 added
package.jsonandpackage-lock.jsonfiles to Twenty Twenty-Two and Twenty Twenty-Five, and those also need updates to the version number. - Twenty Twenty-Three still has no code changes since 1.6. That theme might only have the "Tested up to" version bump, as in r60158, again without packaging a new theme.
@shailu25 commented on PR #10493:
4 months ago
#5
All the mentioned feedback has been incorporated in the latest commit.
This ticket was mentioned in Slack in #core by welcher. View the logs.
4 months ago
@wildworks commented on PR #10493:
4 months ago
#7
The dark.css file has been updated with the following changeset:
https://core.trac.wordpress.org/changeset/60960
If we respect the commit date of the changeset, the new string will be 20251017. If we respect the 6.9 release date, it will be 20251202.
@wildworks commented on PR #10493:
4 months ago
#8
As far as my research goes, that's all the feedback I have. I would appreciate it if someone more knowledgeable could add further reviews.
@shailu25 commented on PR #10493:
4 months ago
#9
The dark.css file has been updated with the following changeset:
https://core.trac.wordpress.org/changeset/60960
If we respect the commit date of the changeset, the new string will be
20251017. If we respect the 6.9 release date, it will be20251202.
I agree this date should be last modified date. I will update this date.
@wildworks commented on PR #10493:
4 months ago
#10
@shail-mehta, The force push may have caused a regression 😅
Released: December 02, 2025 should be Released: December 2, 2025
@shailu25 commented on PR #10493:
4 months ago
#11
Yeah I reverting it
This ticket was mentioned in Slack in #core by wildworks. View the logs.
4 months ago
#13
@
4 months ago
- Keywords commit 2nd-opinion added
This ticket was brought up in the 6.9 Bug SCrub today. From what I can see, it's ready to commit, but I'd appreciate some second feedback from someone more knowledgeable.
@umeshsinghin commented on PR #10493:
4 months ago
#14
I’ve gone through the PR, and it looks all set from my side.
This ticket was mentioned in Slack in #core by wildworks. View the logs.
4 months ago
#16
@
4 months ago
This ticket was brought up in the 6.9 Bug Scrub today again.
I'd like to ping some contributors who have experience with this type of task to get some additional feedback.
cc @sabernhardt @peterwilsoncc @audrasjb @desrosj
#18
@
4 months ago
- Keywords commit 2nd-opinion removed
PR 10493 already updated the version string for these two stylesheets:
- Twenty Eleven
dark.css-20251017 - Twenty Twelve
blocks.css-20251031
We should also update versions for some JS files and the Genericons stylesheets.
Twenty Thirteen
| File | Date |
|---|---|
genericons.css | 20251101
|
functions.js | 20250727
|
Twenty Fourteen
| File | Date |
|---|---|
genericons.css | 20251101
|
functions.js | 20250729
|
Twenty Fifteen
| File | Date |
|---|---|
genericons.css | 20251101
|
functions.js | 20250729
|
color-scheme-control.js | 20250729
|
Twenty Sixteen
| File | Date |
|---|---|
genericons.css | 20251101
|
Twenty Seventeen
| File | Date |
|---|---|
customize-controls.js | 20250717
|
Twenty Nineteen
| File | Date |
|---|---|
touch-keyboard-navigation.js | 20250802
|
customize-controls.js | 20250717
|
This ticket was mentioned in Slack in #core by welcher. View the logs.
4 months ago
#20
@
4 months ago
I've made those adjustments to the PR linked above. I think this is ready to go, but waiting until after RC3 is released in about an hour.
#21
@
3 months ago
Drafts for the changelogs are on https://github.com/WordPress/Documentation-Issue-Tracker/issues/2078
#22
@
3 months ago
The handbook mentions creating POT files for Twenty Ten and Twenty Eleven. Those POT files have not been updated since 2020 ([45289]), and the block patterns added in 2021 ([51103] and [51106]) are translated anyway. However, [60244] made two more strings translatable for Twenty Eleven.
#24
@
3 months ago
- Keywords commit dev-reviewed fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to backport [61329].
@sabernhardt Sorry, I'm not sure why your comment did not show up when I loaded up this ticket before committing above.
I'm honestly not sure how to make that change because the tools/i18n directory has not existed for some time. I think we should consider possibly removing these POT files in favor of language packs from w.org, but I won't have a chance to look into this before the 6.9 release and I'd like some input form someone more familiar with how those work.
@desrosj commented on PR #10493:
3 months ago
#25
Merged in r61329. Thanks everyone!
#26
@
3 months ago
@desrosj Looks good for merge to the 6.9 branch. Neither Trac nor GitHub are showing the full commit diff due to the size of the change so I reviewed the changes at https://github.com/WordPress/wordpress-develop/pull/10493/files
Except for Twenty Twenty-Three, all of the themes have at least one change (as of today).