WordPress.org
Get WordPress

Make WordPress Core

Opened 6 weeks ago

Closed 3 weeks ago

#64074 closed enhancement (wontfix)

Backport Entity Block Binding source

Reported by: get_dave's profile get_dave Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch reporter-feedback
Focuses: Cc:

Description

Backport of ​https://github.com/WordPress/gutenberg/pull/71630

Adds a new "entity" block binding.

Note that this is a placeholder ticket which exists for safety purposes and may not be needed as contributors intended to normalize this binding with existing post and term data bindings.

Change History (8)

#2 @get_dave
6 weeks ago

@bernhard-reiter As per our discussion on Gutenberg repo (​https://github.com/WordPress/gutenberg/pull/71630#issuecomment-3354889752) this ticket acts as a placeholder whilst we look to normalize the data bindings for post data and term data to be more flexible.

Once done I anticipate we can close this ticket as the backport shouldn't be necessary.

#3 @rollybueno
6 weeks ago

  • Keywords reporter-feedback added

Hi @get_dave,

I have tested the PR ​https://github.com/WordPress/wordpress-develop/pull/10141 and I was expecting the navigation link to have "binding" on the code editor, but unfortunately I don't see any of it after checking out in your PR.

Trunk: ​https://imgur.com/zgqWTot
PR 10141: ​https://imgur.com/dzUbDWX

Can you tell me what's missing? and how to test this properly?

Cheers!

#4 follow-up: @get_dave
5 weeks ago

@rollybueno Thank you. It's not possible to test until the latest Gutenberg has been merged to trunk as the features in this ticket are only there to support those changes and don't do anything themselves.

#5 in reply to: ↑ 4 @rollybueno
5 weeks ago

Replying to get_dave:

@rollybueno Thank you. It's not possible to test until the latest Gutenberg has been merged to trunk as the features in this ticket are only there to support those changes and don't do anything themselves.

Thanks for clarifying this.. I guess I'll wait for beta release to give another look..

#6 @wildworks
4 weeks ago

  • Milestone changed from Awaiting Review to 6.9

@get_dave Just to be safe, I'll change the milestone for this ticket to 6.9.

​@get_dave commented on ​PR #10141:
4 weeks ago #7

As we have now ​refactored the implementation to use the existing Post and Term bindings there is no need for a backport. Closing this one out.

cc @ockham

#8 @wildworks
3 weeks ago

  • Milestone 6.9 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As we have now refactored the implementation to use the existing Post and Term bindings there is no need for a backport. Closing this one out.

As I understand it, this ticket no longer needs to be addressed, so I would like to close it.

Note: See TracTickets for help on using tickets.