Trim the GitHub Actions workflows for older branches (and possibly `trunk`)

[johnbillion]

For older branches (ie. prior to 6.9 currently) I propose:

1. Unused workflow files (mostly the reusable ones) are trimmed. This has been done previously on an ad-hoc basis, this is just catching up recent branches.
2. The performance.yml workflow is additionally removed. Realistically this is not something that anybody looks at outside of trunk and the current major, and results for branches aren't available on codevitals.run.
3. The matrices for PHPUnit tests are reduced to boundary testing of each major PHP version, which means the highest and lowest supported version in each of 5, 7, and 8. This reduces the time for tests to run and reduces the number of minutes consumed by workflows. This is especially useful when preparing backports to multiple branches.

For the 6.7 branch:

• Deletes unnecessary workflows
• Trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

[desrosj]

After the bottleneck that occurred leading up to the 6.9 beta 1 release that resulted in the need for [61018], I am going to move this to the 7.0 milestone.

While [61018] was a great short-term fix, it is not a sustainable way to limit the number of jobs long-term. I've updated the ticket summary to also include trunk.

[desrosj]

In 61225:

Build/Test Tools: Revert [61018].

[61018] was a good way to quickly limit the number of jobs spawned by the PHPUnit test workflow during the time leading up to beta releases for the 6.9 release, but this approach is not sustainable. This reverts that commit so a better long term solution can be explored in #64083.

See #63170, #64083.

[peterwilsoncc]

In 61256:

Build/Test Tools: Revert [61018].

[61018] was a good way to quickly limit the number of jobs spawned by the PHPUnit test workflow during the time leading up to beta releases for the 6.9 release, but this approach is not sustainable. This reverts that commit so a better long term solution can be explored in #64083.

Reviewed by peterwilsoncc.
Merges [61225] to the 6.9 branch.

See #63170, #64083.

[johnbillion]

In 61736:

Build/Test Tools: Trim the 6.7 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branchand database version.

Props desrosj, johnbillion

See #64083

https://core.trac.wordpress.org/changeset/61736

Previously: #10165

Previously: #10165

The reusable workflow files have already been removed from this branch.

Previously: #10165

The reusable workflow files have already been removed from this branch.

Previously: #10165

The reusable workflow files have already been removed from this branch.

Previously: #10165

• The reusable workflow files have already been removed from this branch.
• This additionally pins the e2e test workflow to PHP 8.2 as they fail on latest (which is 8.3) in this branch.

Previously: #10165

• The reusable workflow files have already been removed from this branch.
• The e2e test workflow in this branch is already pinned to PHP 8.0.

[johnbillion]

In 61801:

Build/Test Tools: Trim the 6.6 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branch and database version.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61802:

Build/Test Tools: Trim the 6.5 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branch and database version.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61803:

Build/Test Tools: Trim the 6.4 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branch and database version.

Props desrosj, johnbillion

See #64083

https://core.trac.wordpress.org/changeset/61801

https://core.trac.wordpress.org/changeset/61802

https://core.trac.wordpress.org/changeset/61803

[johnbillion]

In 61804:

Build/Test Tools: Trim the 6.3 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branch and database version.

Props desrosj, johnbillion

See #64083

https://core.trac.wordpress.org/changeset/61804

[johnbillion]

In 61805:

Build/Test Tools: Trim the 6.2 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branch and database version.

Props desrosj, johnbillion

See #64083

https://core.trac.wordpress.org/changeset/61805

[johnbillion]

In 61806:

Build/Test Tools: Trim the 6.1 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branch and database version.

Props desrosj, johnbillion

See #64083

https://core.trac.wordpress.org/changeset/61806

Previously: #10165

• The reusable workflow files have already been removed from this branch.
• The e2e test workflow in this branch is already pinned to PHP 8.0.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e test workflow in this branch is already pinned to PHP 8.0.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e test workflow in this branch is already pinned to PHP 8.0.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

This trims the matrix down to PHP 5.3-5.6 and 7.0-7.3, the difference from later branches is the 5.6 and 7.0 jobs are built from the include directive instead of directly in the martrix due to the older PHPUnit version requirements.

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

This trims the matrix down to PHP 5.3, 5.6, 7.0, and 7.3. Similarly to the 5.1 branch, the 5.6, 7.0, and 7.3 jobs are built from the include directive instead of directly in the matrix due to the older PHPUnit version requirements.

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

This trims the matrix down to PHP 5.3, 5.6, 7.0, and 7.2. Similarly to the 5.0 and 5.1 branches, the later jobs are built from the include directive instead of directly in the matrix due to the older PHPUnit version requirements.

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

This trims the matrix down to PHP 5.3, 5.6, 7.0, and 7.1. The 5.6 jobs are built from the include directive.

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

Previously: #10165

This trims the matrix down to PHP 5.3, 5.6, 7.0, and 7.1. The 5.6 and 7.x jobs are built from the include directive.

• No workflow files need deleting from this branch.
• The e2e workflow doesn't exist in this branch.

@johnbillion What do you think of also trimming 8.1 here? It's set to allow-failures. The release did have beta support. But if the suite does not fully pass to begin with, is it worth keeping those combinations?

I reviewed this one after th 5.9 PR (#11136). But the same question goes for that branch also.

[johnbillion]

In 61810:

Build/Test Tools: Trim the 6.0 workflows.

This removes reusable workflows that are no longer referenced in the branch, and trims the unit testing matrix to the highest and lowest supported version of each major PHP branch and database version.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61811:

Build/Test Tools: Trim the 5.9 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61812:

Build/Test Tools: Trim the 5.8 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61813:

Build/Test Tools: Trim the 5.7 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61814:

Build/Test Tools: Trim the 5.6 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61815:

Build/Test Tools: Trim the 5.5 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61816:

Build/Test Tools: Trim the 5.4 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61817:

Build/Test Tools: Trim the 5.3 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61818:

Build/Test Tools: Trim the 5.2 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61819:

Build/Test Tools: Trim the 5.1 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61820:

Build/Test Tools: Trim the 5.0 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61821:

Build/Test Tools: Trim the 4.9 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61822:

Build/Test Tools: Trim the 4.8 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

See #64083

[johnbillion]

In 61823:

Build/Test Tools: Trim the 4.7 workflows.

This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch.

Props desrosj, johnbillion

Fixes #64083

https://core.trac.wordpress.org/changeset/61810

https://core.trac.wordpress.org/changeset/61811

https://core.trac.wordpress.org/changeset/61810

https://core.trac.wordpress.org/changeset/61820

[desrosj]

@johnbillion reopening this because it seems like the commit to the 6.0 branch caused some ​unexpected changes to the built files.

I noticed the 6.0-branch branch as one of two in the Active list by chance looking into whether the branch created in [61863] made it to the WordPress/WordPress mirror on GitHub.

I'm not at all clear what caused this since no changes were made to package.json or package-lock.json, but a good number of JavaScript files and any generated files containing computed hashes of those files were updated. The changes all seem similar to what you'd expect if webpack or a related dependency were updated, and I believe the changes all look OK.

But this will increase the package size for the next 6.0 auto-update should a security patch need to be shipped to this branch.

I'm reopening for now just to look into this a bit more. It would be good to understand what happened.

[johnbillion]

Jon and I looked through the branches that were changed last week (4.7 - 6.9). The only affected branch is 6.0. I'll speak with the systems team to find out what changed on the build server since ​the last commit in the 6.0 branch in November.

[johnbillion]

​https://make.wordpress.org/systems/?p=2747

[johnbillion]

CC @isabel_brison, @peterwilsoncc, @sergeybiryukov, @davidbaumwald, see the comments above. I was just pointed to [57982] by @jorbin. Do you have any idea why the built files in the 6.0 branch might have changed?

[johnbillion]

Another observation: The unexpected change to built files on a branch is completely invisible without manually checking every commit. This seems like a major blind spot, not only for unintentional errors like the above but also as a supply chain security concern.

[desrosj]

In 62035:

Build/Test Tools: Trim performance workflow from 6.7-6.4.

[61736], [61801], [61082], and [61083] removed the performance.yml workflow from the 6.7-6.4 branches as part of #64083.

The workflow also needs to be removed from the workflow responsible for testing old branches to avoid failures when attempting to trigger a workflow_dispatch event on a non-existent workflow file.

See #64227, #64083.

[desrosj]

#64297 was marked as a duplicate.

[johnbillion]

In 62181:

Build/Test Tools: Revert [61810] while we investigate issues with the build process for the 6.0 branch.

See #64083

[johnbillion]

In 62183:

Build/Test Tools: Trim the 6.0 workflows.

This is a re-commit of [61810] which was reverted in [62181].

See #64083