Missing parentheses in condition in delete_metadata()

[threadi]

In wp-includes/meta.php inside the function delete_metadata() if the following if-condition:

if ( ! $meta_type || ! $meta_key || ! is_numeric( $object_id ) && ! $delete_all ) {
 return false;
}

There is a missing parentheses around the last two conditions on this line. As a result, the condition will not be true in the cases where it should be.

A correction would look like this:

if ( ! $meta_type || ! $meta_key || ( ! is_numeric( $object_id ) && ! $delete_all ) ) {
 return false;
}

Source: ​https://github.com/WordPress/WordPress/blob/master/wp-includes/meta.php#L402

[jorbin]

Introduced in [29421].

Can you write some unit tests that demonstrate this being an issue? With it being 11 years that this behavior has been a part of core, I think it's important to understand exactly what the change would mean.

[TobiasBg]

I actually think that the && is evaluated before the || even without parentheses.

[Presskopp]

I go with @TobiasBg

[SergeyBiryukov]

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

Replying to TobiasBg:

I actually think that the && is evaluated before the || even without parentheses.

Yes, see ​PHP: Operator Precedence. The condition is correct as is, and the additional parentheses would be redundant here.

[Presskopp]

Nowhere in the coding standards does it say that we should use parentheses for clarity. Since this works well as it is, let's close the case.