Notes: PHP backports from Gutenberg

[wildworks]

Gutenberg Issue: ​https://github.com/WordPress/gutenberg/issues/71826

We plan to stabilize "Notes" feature (formerly known as Block Comments) for the 6.9 release. The Notes feature requires extending the comments REST API, and we need to backport the PHP changes made in Gutenberg into core.

• Related Gutenberg Issue: ​https://github.com/WordPress/gutenberg/issues/71826
• Related Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/72344

This PR updates the core Comments REST API to allow the Notes feature to work properly.

Ok, I believe backporting PHP should be all done. Next, I'll try to fix the failing tests.

Ok, I believe backporting PHP should be all done. Next, I'll try to fix the failing tests.

I think we're missing the Notes-specific unit tests.

Thanks both of you for your feedback! I got a bit confused about the JS fixtures, so I've put them back to how they were 😄 I'll look into how to update them properly.

[wildworks]

#64012 was marked as a duplicate.

I got a bit confused about the JS fixtures, so I've put them back to how they were

For some reason I no longer get the error.

Ditto all the feedback about wishing we had a fleshed out comment types API about now. But I think this looks pretty reasonable.

Curious, does this work well with WP-CLI out of the box when dealing with comments?

Curious, does this work well with WP-CLI out of the box when dealing with comments?

Do you have any particular concerns, @swissspidy? I've only used WP-CLI to clean up test data or migrate notes after the type change. It worked perfectly.

@t-hamano, what are the remaining blockers here?

@t-hamano, what are the remaining blockers here?

I think I've addressed all the feedback.

I haven't committed to core yet, so I'd be happy if someone could do that 😅 That said, I'd like to set up an SVN environment, understand ​the core committer workflow, and try my hand at committing within the 6.9 cycle.

I haven't committed to core yet, so I'd be happy if someone could do that 😅 That said, I'd like to set up an SVN environment, understand ​the core committer workflow, and try my hand at committing within the 6.9 cycle.

@t-hamano - I'm happy to take this commit so your first effort isn't so large!

[adamsilverstein]

This looks ready for commit, I am going to work on that.

[adamsilverstein]

In 60987:

Editor: Introduce the PHP-related code for Notes.

Bring the PHP part of the new Notes feature into core for the 6.9 release. See related Gutenberg Issue: ​https://github.com/WordPress/gutenberg/issues/71826. These changes do not impact any user facing functionality, they simply prepare core for the JavaScript functionality that will come over in a separate sync.

Overview of changes:

• Ensure Notes are not included in comment counts
• Enable the note type (REST API)
• Adjust capabilities so edit_post cap implies ability to edit notes
• Enable empty and duplicate notes for resolve/re-open actions
• Add control over notes with post type supports check
• Register new note resolution status meta

Props: ristojovanovic, adamsilverstein, jeffpaul, wildworks, mamaduka, swissspidy, timothyblynjacobs, kadamwhite.
Fixes #64096.

@desrosj any idea why the Playground bot commented after the PR was closed versus after it was opened? Seems like it ideally triggers after a PR is opened so folks have an easy way to test, yeah?

@jeffpaul The workflow that leaves the Playground comment runs when the Test Build Process workflow completes (the results of the build process are zipped and uploaded to these runs).

Looking at the timeline of events on the PR, I think what happened was as follows:

• ​https://github.com/WordPress/wordpress-develop/pull/10280/commits/2ad2332cd4d4bddc46a6ecb999ac8402cc48237b was merged into the HEAD branch.
• ~10 minutes later, the commit to trunk was made and mirrored to this repository in ​https://github.com/WordPress/wordpress-develop/commit/c62fe7e3322fd50d1d912048a879dbbf94e5dab1.
• The Test Build Process workflow was probably still running at this time, or had not started and was queued because of the log jam that happened leading up to beta 1.
• The workflow finally finished and triggered the commenting workflow ~30 minutes later.

The commenting workflow does _not_ currently check if the PR has been closed before posting. It just relies on the prerequisite workflow run completing. There is Core-61568 on Trac that is aimed at only sharing a Playground link when the changes are being made would actually be testable within a Playground instance. For example, GitHub Action workflow files cannot be tested in Playground. I am going to add this to a comment on that ticket so it does not get lost.

Despite being reported several times and continually deleting the content, this account continues to spam this PR. I am going to lock the conversation for this PR to avoid the massive amounts of noise.