Opened 7 months ago
Closed 6 months ago
#64101 closed enhancement (fixed)
Update to PHPMailer 7.0.0
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.9 | Priority: | normal |
| Severity: | trivial | Version: | |
| Component: | External Libraries | Keywords: | has-patch commit dev-reviewed |
| Focuses: | Cc: |
Description (last modified by )
This update is only bureaucratic. There was a SemVer mistake with versioning, so basically the current version we are shipping only needs a bump in numbering to be compliant.
I attach below the minuscule patch.
More info about the update
https://github.com/PHPMailer/PHPMailer/releases/tag/v7.0.0
Change History (14)
This ticket was mentioned in PR #10287 on WordPress/wordpress-develop by @SirLouen.
7 months ago
#1
- Keywords has-patch added
@mukesh27 commented on PR #10287:
7 months ago
#3
The v6.12.0 version have some file changes https://github.com/PHPMailer/PHPMailer/compare/v6.12.0...v7.0.0 why 7.0 didn't have any 🤔
@SirLouen commented on PR #10287:
7 months ago
#4
It was a semver update mistake, better explained in Trac ticket
@mukesh27 commented on PR #10287:
7 months ago
#5
Thanks! Approved ✅
#6
@
7 months ago
- Milestone changed from 6.9 to 7.0
Since the 6.9 Beta1 release is coming soon, let's punt this ticket to 7.0. If you can commit before Beta1, feel free to change the milestone back to 6.9.
#7
@
6 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 61249:
#8
follow-up:
↓ 9
@
6 months ago
- Milestone changed from 7.0 to 6.9
- Resolution fixed deleted
- Status changed from closed to reopened
As the current version in the 6.9 branch was retagged upstream, thus the small changeset on this ticket, I think it would be good to backport [61249].
Specifically, lang(), setLanguage(), and $language are now static, and should be called statically.
Additionally, will the code in `WP_Locale_Switcher::change_locale()` need an update given the above?
#9
in reply to:
↑ 8
@
6 months ago
Replying to peterwilsoncc:
Additionally, will the code in
WP_Locale_Switcher::change_locale()need an update given the above?
This update was a little tricky. This update was done in a previous point version, but it violated the semver rules, hence, a forced update to 7.0.0 without any changes (this) was introduced after. The code you mention is already updated and merged into 6.9 (prev to RC1).
If you want you can leave this fixed into 7.0 without the need of a backport, no real changes are worthy here.
#10
follow-up:
↓ 11
@
6 months ago
@SirLouen I think it would be good to backport the version number changes as the PHPMailer 6.11.0 and 6.11.1 include changes that were reverted in 6.12.0 but retained in 7.0.0. If a developer is calling version_compare() to determine if these changes are included, it will need to be a messy condition if ( version >= 7.0.0 || version == 6.11.0 || version == 6.11.1 )
Additionally, will the code in
WP_Locale_Switcher::change_locale()need an update given the above?
No, because I misread the code on Sunday.
#11
in reply to:
↑ 10
@
6 months ago
Replying to peterwilsoncc:
@SirLouen I think it would be good to backport the version number changes as the PHPMailer 6.11.0 and 6.11.1 include changes that were reverted in 6.12.0 but retained in 7.0.0. If a developer is calling
version_compare()to determine if these changes are included, it will need to be a messy conditionif ( version >= 7.0.0 || version == 6.11.0 || version == 6.11.1 )
True, and backporting is pretty simple.
Trac ticket: https://core.trac.wordpress.org/ticket/64101