Query: undefined variable $q in WP_Query::generate_cache_key()

[ramonopoly]

Follow up to https://core.trac.wordpress.org/ticket/59442

The generate_cache_key() method in WP_Query references an undefined variable $q on line 5046:

<?php
if ( ! isset( $q['orderby'] ) ) {
    $args['orderby'] = 'date';
}

The method only has two parameters: $args and $sql. The variable $q is not defined anywhere in this method scope.

This fix is to replace the undefined $q variable with the correct $args parameter:

<?php
if ( ! isset( $args['orderby'] ) ) {
    $args['orderby'] = 'date';
}

Follow up to: https://core.trac.wordpress.org/ticket/59442

The generate_cache_key() method in WP_Query references an undefined variable $q on line 5046:

if ( ! isset( $q['orderby'] ) ) {
    $args['orderby'] = 'date';
}

The method only has two parameters: $args and $sql. The variable $q is not defined anywhere in this method scope.

Introduced in https://core.trac.wordpress.org/changeset/58122 / ​https://github.com/10up/wordpress-develop/commit/3a6cca9ff772c77c86a3cf7c5a69398acc4c2272

This patch replaces the undefined $q variable with the correct $args parameter:

if ( ! isset( $args['orderby'] ) ) {
    $args['orderby'] = 'date';
}

Thanks @westonruter 🙇🏻

[ramonopoly]

In 61043:

Query: fix undefined variable $q in WP_Query::generate_cache_key()

The generate_cache_key() method in WP_Query referenced an undefined variable $q. The method only has two parameters: $args and $sql. The variable $q is not defined anywhere in this method scope. This patch replaces the undefined $q variable with the correct $args parameter.

Follow-up to [59442]

Props ramonopoly, westonruter

Fixes #64135.

Committed to r61043

[westonruter]

This bug had the effect of always overriding the orderby query arg to be date when generating a cache key, potentially colliding with another cached query with a different orderby.