Opened 6 months ago
Last modified 2 months ago
#64217 assigned defect (bug)
Comment approval/type check runs after `notify_post_author` filter
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.1 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Comments | Keywords: | has-patch needs-refresh changes-requested |
| Focuses: | Cc: |
Description (last modified by )
The notify_post_author filter "Filters whether to send the post author new comment notification emails, overriding the site setting.". However the current code performs two logic checks after the filter - before actually sending the notification. Notifications are only sent if the comment type is a note, or the comment is approved. notifications are not sent for unapproved comments, even when notify_post_author returns true.
Therefore, it makes sense to move these logic checks _before_ the filter which would give developers core complete control over notifications.
Change History (9)
This ticket was mentioned in PR #10489 on WordPress/wordpress-develop by @adamsilverstein.
6 months ago
#1
- Keywords has-patch added
#2
@
6 months ago
- Milestone changed from Awaiting Review to 7.0
- Owner set to adamsilverstein
- Status changed from new to assigned
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
3 months ago
#5
@
3 months ago
- Keywords needs-refresh changes-requested added
As per today's 7.0 bug scrub:
This ticket has a PR which only needs to be refreshed against trunk and some adjustments (like since tags and a small wpcs fix). Pinging @adamsilverstein if you have the time to close this one.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 months ago
#7
@
2 months ago
The PR is ready, however we should probably just punt to 7.1 given the lateness in the cycle, this is more of an edge case bug anyway. What do you think @westonruter ?
Trac ticket: https://core.trac.wordpress.org/ticket/64217