Make WordPress Core

Opened 5 weeks ago

Last modified 5 weeks ago

#64217 assigned defect (bug)

Comment approval/type check runs after `notify_post_author` filter

Reported by: adamsilverstein's profile adamsilverstein Owned by: adamsilverstein's profile adamsilverstein
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: Cc:

Description (last modified by adamsilverstein)

The notify_post_author filter "Filters whether to send the post author new comment notification emails, overriding the site setting.". However the current code performs two logic checks after the filter - before actually sending the notification. Notifications are only sent if the comment type is a note, or the comment is approved. notifications are not sent for unapproved comments, even when notify_post_author returns true.

Therefore, it makes sense to move these logic checks _before_ the filter which would give developers core complete control over notifications.

Change History (3)

This ticket was mentioned in PR #10489 on WordPress/wordpress-develop by @adamsilverstein.


5 weeks ago
#1

  • Keywords has-patch added

#2 @adamsilverstein
5 weeks ago

  • Milestone changed from Awaiting Review to 7.0
  • Owner set to adamsilverstein
  • Status changed from new to assigned

#3 @adamsilverstein
5 weeks ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.