WordPress.org
Get WordPress

Make WordPress Core

Opened 4 weeks ago

Last modified 10 days ago

#64221 reviewing task (blessed)

Reclassify `json2php` as a `devDependency`

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug has-patch
Focuses: Cc:

Description

It looks like json2php is included in the list of dependencies, but it appears the package is only used within the copy:block-json Grunt task to convert block.json file contents to a block-json.php equivalent.

The package is even explicitly excluded from the unit test that asserts that all dependencies are registered and available as expected.

Change History (3)

This ticket was mentioned in ​PR #10520 on ​WordPress/wordpress-develop by ​@royhridoy.
3 weeks ago #1

  • Keywords has-patch added; needs-patch removed

The json2php package is only used by the build process and is not required at runtime. It is even explicitly excluded from the runtime dependency unit test.

This change moves json2php from dependencies to devDependencies and regenerates the lockfile.

Trac ticket: Core-64221

#2 @SergeyBiryukov
3 weeks ago

  • Milestone changed from Awaiting Review to 7.0

#3 @westonruter
10 days ago

  • Owner set to desrosj
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.