Make WordPress Core

#64254 closed defect (bug) (fixed)

Fix: Custom font size taking over fit text

Reported by: jorgefilipecosta Owned by: jorgefilipecosta
Priority: normal Milestone: 6.9
Component: Editor Version:
Severity: normal Keywords: has-patch dev-reviewed
Cc: Focuses:

Description

Currently we have an issue where if a paragraph/heading had a custom font size and then was converted to the stretchy variation. The custom font size on the front end is applied instead of fit text.
It was fixed in Gutenberg at ​https://github.com/WordPress/gutenberg/pull/73241, and this ticket tracks the fix in WordPress core.

Change History (7)

This ticket was mentioned in ​PR #10517 on ​WordPress/wordpress-develop by ​@jorgefilipecosta.


11 months ago
#1

Backports ​https://github.com/WordPress/gutenberg/pull/73241 into the core.

Fixes an issue where if a paragraph/heading had a custom font size and then was conververted to the stretchy variation. The custom font size on the front end was applied instead of fit text.

cc: @mrwweb

Ticket: https://core.trac.wordpress.org/ticket/64254

## Testing
Insert Paragraph block
Type some text in it
Set a non-default font size for the Paragraph block
Switch the Paragraph to the fit text Paragraph variation
The front-end of the site should not use the font size setting selected in Step 3 and should instead show fit text working normally as in the editor.

#2 @jorgefilipecosta
11 months ago

  • Owner set to jorgefilipecosta
  • Resolution → fixed
  • Status new → closed

In 61246:

Fix: Custom font size taking over fit text.

Fixes an issue where if a paragraph/heading had a custom font size and then was conververted to the stretchy variation. The custom font size on the front end was applied instead of fit text.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/10517

Props jorgefilipecosta, mcsf, mrwweb.
Fixes #64254.

#3 @jorgefilipecosta
11 months ago

  • Keywords dev-feedback added
  • Resolution fixed
  • Status closed → reopened

Reopening for backport.

This ticket was mentioned in ​Slack in #core by wildworks. ​View the logs.


11 months ago

#5 @wildworks
11 months ago

Reopening for backport.

Approved ✅

#6 @jorgefilipecosta
11 months ago

  • Keywords dev-reviewed added; dev-feedback removed

#7 @jorgefilipecosta
11 months ago

  • Resolution → fixed
  • Status reopened → closed

In 61251:

Fix: Custom font size taking over fit text.

Fixes an issue where if a paragraph/heading had a custom font size and then was conververted to the stretchy variation. The custom font size on the front end was applied instead of fit text.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/10517.

Props jorgefilipecosta, mcsf, mrwweb, t-hamano.
Fixes #64254.

Note: See TracTickets for help on using tickets.