WordPress.org
Get WordPress

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#64289 closed defect (bug) (fixed)

Media Library - textual fix in Help tab

Reported by: Guido07111975 Owned by: SergeyBiryukov
Priority: normal Milestone: 7.0
Component: Help/About Version: 6.8.3
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Minor textual fix in Help tab of the Media page (Grid View).
Make button names in Help info match button names at Media page.

Attachments (2)

Grid View 1.jpg​ (64.7 KB ) - added by Guido07111975 9 months ago.
Grid View 2.jpg​ (62.6 KB ) - added by Guido07111975 9 months ago.

Download all attachments as: .zip

Change History (10)

@Guido07111975
9 months ago

@Guido07111975
9 months ago

This ticket was mentioned in ​PR #10539 on ​WordPress/wordpress-develop by ​@Guido07111975.
9 months ago #1

Minor textual fix in Help tab of the Media page (Grid View).
Make button names in Help info match button names at Media page.

Trac ticket: Ticket #64289

https://github.com/user-attachments/assets/a457cc37-50d9-4cfa-9657-cd2b8864c762

https://github.com/user-attachments/assets/37ea171d-9779-4af0-802d-c91098e847c3

#2 @SergeyBiryukov
9 months ago

  • Milestone Awaiting Review → 7.0

#3 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 61277:

Help/About: Update button labels for bulk select in Media Library help text.

Follow-up to [29484], [29646], [45147].

Props Guido07111975.
Fixes #64289.

#4 @Guido07111975
9 months ago

@SergeyBiryukov: Can I close my PR, as you have fixed it yourself?

​@SergeyBiryukov commented on ​PR #10539:
9 months ago #5

Thanks for the PR! Merged in r61277.

#6 follow-up: @Guido07111975
9 months ago

@SergeyBiryukov:
You've wrapped the button names in double quotes, but I don't see that in other Help info tabs. Mostly no quotes or the button/link name is wrapped in bold tags.

#7 in reply to: ↑ 6 @SergeyBiryukov
9 months ago

  • Resolution fixed
  • Status closed → reopened

Replying to Guido07111975:

You've wrapped the button names in double quotes, but I don't see that in other Help info tabs. Mostly no quotes or the button/link name is wrapped in bold tags.

You're right that it's not super consistent with the other tabs, but the difference is that the other button labels use title case, while these use sentence case and look more appropriate with the quotes to me. We could maybe switch the quotes to bold selection though, good catch!

#8 @SergeyBiryukov
9 months ago

  • Resolution → fixed
  • Status reopened → closed

In 61279:

Help/About: Use <strong> tags instead of double quotes in Media Library help text.

This aims to make the styling of button references more consistent across the help tabs.

Follow-up to [61277].

Props Guido07111975.
Fixes #64289.

Note: See TracTickets for help on using tickets.