![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 8 months ago
Last modified 5 days ago
#64298 reopened enhancement
Move the `failed-workflow` job logic into a reusable workflow
| Reported by: | desrosj | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | good-first-bug has-patch |
| Cc: | Focuses: |
Description
The failed-workflow job is present in all workflows that run on push events in all branches receiving security updates.
While the logic within the job is minimal, it still relies on a 3rd-party action and backports are required periodically to ensure the job continues working as expected.
The logic within this job should be moved to a reusable workflow in trunk that all other branches can reference. This not only eliminates the maintenance burden, but also allows older branches to take advantage of any improvements made to the logic without needing to backport.
Attachments (1)
Change History (11)
#2
@
5 months ago
- Resolution → wontfix
- Status new → closed
This is a very sensible improvement. Moving the failed-workflow job into a reusable workflow in trunk will significantly reduce maintenance overhead and eliminate the need for repeated backports across multiple branches.
#3
@
5 months ago
- Resolution wontfix
- Status closed → reopened
Hi @atik0130961,
Please leave tickets open until they’re addressed in a commit.
#4
@
3 months ago
Reviewed the ticket and patch.
Moving the failed-workflow job to a reusable workflow makes sense given the duplication across workflows.
This should improve maintainability across branches.
#5
@
3 months ago
- Keywords has-patch added
- Milestone Future Release → 7.1
Hi @bsetiawan88,
Could you please open a pull request against WordPress/wordpress-develop on GitHub? That will help validate that the workflow files are valid after applying the patch on this ticket. You'll find some guidance around how to contribute using GitHub in the Core Gandbook.
This ticket was mentioned in PR #11425 on WordPress/wordpress-develop by @kapilpaul.
3 months ago
#6
Trac ticket: https://core.trac.wordpress.org/ticket/64298
## Use of AI Tools
This ticket was mentioned in PR #11349 on WordPress/wordpress-develop by @johnbillion.
3 months ago
#7
#8
@
3 months ago
Alternate approach: https://github.com/WordPress/wordpress-develop/pull/11349. Needs testing on a separate repo because it only fires when the workflow is present in the default branch.
Marking as a
good-first-bugfor the first part of this ticket: moving the logic into a reusable workflow.After this is fixed in
trunk, then it can be backported to older branches (which is not so much a good first bug to do).