Make WordPress Core

Opened 12 months ago

Last modified 4 months ago

#64298 reopened enhancement

Move the `failed-workflow` job logic into a reusable workflow

Reported by: desrosj Owned by:
Priority: normal Milestone: Future Release
Component: Build/Test Tools Version:
Severity: normal Keywords: good-first-bug has-patch
Cc: Focuses:

Description

The failed-workflow job is present in all workflows that run on push events in all branches receiving security updates.

While the logic within the job is minimal, it still relies on a 3rd-party action and backports are required periodically to ensure the job continues working as expected.

The logic within this job should be moved to a reusable workflow in trunk that all other branches can reference. This not only eliminates the maintenance burden, but also allows older branches to take advantage of any improvements made to the logic without needing to backport.

Attachments (1)

patch.diff​ (12.8 KB ) - added by bsetiawan88 8 months ago.

Download all attachments as: .zip

Change History (11)

#1 @desrosj
12 months ago

  • Keywords good-first-bug added

Marking as a good-first-bug for the first part of this ticket: moving the logic into a reusable workflow.

After this is fixed in trunk, then it can be backported to older branches (which is not so much a good first bug to do).

#2 @atik0130961
8 months ago

  • Resolution → wontfix
  • Status new → closed

This is a very sensible improvement. Moving the failed-workflow job into a reusable workflow in trunk will significantly reduce maintenance overhead and eliminate the need for repeated backports across multiple branches.

#3 @desrosj
8 months ago

  • Resolution wontfix
  • Status closed → reopened

Hi @atik0130961,

Please leave tickets open until they’re addressed in a commit.

#4 @moisesfonseca
7 months ago

Reviewed the ticket and patch.
Moving the failed-workflow job to a reusable workflow makes sense given the duplication across workflows.
This should improve maintainability across branches.

#5 @desrosj
7 months ago

  • Keywords has-patch added
  • Milestone Future Release → 7.1

Hi @bsetiawan88,

Could you please open a pull request against WordPress/wordpress-develop on GitHub? That will help validate that the workflow files are valid after applying the patch on this ticket. You'll find some ​guidance around how to contribute using GitHub in the Core Gandbook.

This ticket was mentioned in ​PR #11425 on ​WordPress/wordpress-develop by ​@kapilpaul.


7 months ago
#6

Trac ticket: https://core.trac.wordpress.org/ticket/64298

## Use of AI Tools

This ticket was mentioned in ​PR #11349 on ​WordPress/wordpress-develop by ​@johnbillion.


7 months ago
#7

#8 @johnbillion
7 months ago

Alternate approach: ​https://github.com/WordPress/wordpress-develop/pull/11349. Needs testing on a separate repo because it only fires when the workflow is present in the default branch.

This ticket was mentioned in ​Slack in #core by adrianduffell. ​View the logs.


4 months ago

#10 @adrianduffell
4 months ago

  • Milestone 7.1 → Future Release

Moving this ticket to a future release, as it looks unlikely to be completed before the upcoming 7.1 beta.

Note: See TracTickets for help on using tickets.