Make WordPress Core

Opened 3 weeks ago

Last modified 2 weeks ago

#64300 new defect (bug)

Twenty Twenty-Four and Twenty Twenty-Five: Long links overflow content area

Reported by: cagrimmett's profile cagrimmett Owned by:
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: css Cc:

Description (last modified by sabernhardt)

In the Twenty Twenty-Four and Twenty Twenty-Five themes, long links overflow their content area containers, and if long enough, results in a horizontal scroll bar.

In my testing, this can be fixed by adding an overflow-wrap: break-word; and word-wrap: break-word; (for older browsers) to links.

For TT5, this would go on line 685 of theme.json

"css": "& { overflow-wrap: break-word; word-wrap: break-word; }"

For TT4, it would go on line 894 of theme.json

See attached screenshots for how long links look in content now and how they look with the suggested fix applied.

Now:
a long URL with an access token extends beyond the content container and causes a horizontal scrollbar

With suggested fix:
the long URL wraps within the content container

Change History (5)

#1 @westonruter
3 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 7.0

#2 @wildworks
3 weeks ago

Related: #56341

To be precise, this issue isn't a problem with links. It occurs when there is long text without word separators.

This issue can be reproduced in all default block themes: Twenty Twenty Two, Twenty Twenty Three, Twenty Twenty Four, and Twenty Twenty Five. Rather than fixing it for each theme, we might want to add the text wrapping option to the global styles. See https://github.com/WordPress/gutenberg/issues/55190 for more details.

#3 follow-up: @cagrimmett
2 weeks ago

@wildworks The thought behind changing it in the theme and restricting it to only links is that links are most likely to be the problem (most likely to be long, unbroken strings in content) and restricting it to links fixes that problem without causing unintended consequences.

Might setting that globally produce unintended consequences?

#4 @wildworks
2 weeks ago

Might setting that globally produce unintended consequences?

It's probably fine, but the default block themes have avoided adding custom CSS whenever possible. I think that's the design goal of block themes.

However, at the moment there seems to be no solution other than adding CSS, so it may be a good idea to add CSS until the global styles are strengthened.

#5 in reply to: ↑ 3 @sabernhardt
2 weeks ago

  • Component changed from Themes to Bundled Theme
  • Description modified (diff)
  • Version trunk deleted

links are most likely to be the problem (most likely to be long, unbroken strings in content)

#56341 also gives long, linked URLs as an example, but link text should be kept concise and should avoid including full URLs. Seeing the text break the entire page might help encourage authors to write better link text.

The example articles listed in the image have titles that would fit well for link text, and URL parts such as access tokens and UTM parameters ideally would never be visible on screen or spoken.


If we change the four individual themes' CSS, T22 and T25 have their own CSS files, and #63875 already adjusted those for pre element overflow.

Note: See TracTickets for help on using tickets.