WordPress.org
Get WordPress

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#64336 closed defect (bug) (fixed)

One removed SimplePie file was not added to `$_old_files` in WP 6.9

Reported by: wfmattr's profile WFMattR Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9.1 Priority: normal
Severity: normal Version: 6.9
Component: General Keywords: has-patch dev-reviewed commit fixed-major
Focuses: Cc:

Description

When updating a site from 6.8.3 to 6.9, wp-includes/SimplePie/src/Decode and its subdirs and contained file were correctly removed, but wp-includes/SimplePie/src/Core.php still remains.

The $_old_files array was updated in trac ticket #64320. Core.php was mentioned in the list at the top of the ticket, but it looks like it was just missed in the array.

Change History (9)

#1 @davidbaumwald
5 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 6.9.1

This ticket was mentioned in ​PR #10584 on ​WordPress/wordpress-develop by ​@sajib1223.
5 months ago #2

  • Keywords has-patch added; needs-patch removed

Added wp-includes/SimplePie/src/Core.php file to the $_old_files array.

Trac ticket: https://core.trac.wordpress.org/ticket/64336

#3 follow-up: @mukesh27
5 months ago

Is there anything we should take care of before the general release? Do we need to document this somewhere so we can address it before the release?

#4 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 61351:

Upgrade/Install: Add missing file to the $_old_files array.

Follow-up to [60490], [61338].

Props WFMattR, sajib1223, davidbaumwald, mukesh27, SergeyBiryukov.
Fixes #64336.

#6 @SergeyBiryukov
5 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 6.9 branch.

#7 in reply to: ↑ 3 @desrosj
5 months ago

  • Keywords dev-reviewed commit added; dev-feedback removed

Replying to mukesh27:

Is there anything we should take care of before the general release? Do we need to document this somewhere so we can address it before the release?

@mukesh27 I'm not sure what you mean here. Could you clarify? I think what you're asking is if the release checklists need to be updated to make sure this is not missed next time. Is that right?

[61351] looks good to backport.

#8 @SergeyBiryukov
5 months ago

  • Keywords fixed-major added

#9 @peterwilsoncc
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 61383:

Upgrade/Install: Add missing file to the $_old_files array.

Follow-up to [60490], [61338].

Reviewed by desrosj.
Merges [61351] to the 6.9 branch.

Props WFMattR, sajib1223, davidbaumwald, mukesh27, SergeyBiryukov.
Fixes #64336.

Note: See TracTickets for help on using tickets.