WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 9 months ago

#64348 closed defect (bug) (fixed)

The `$embeds` element is missing from the `wp_mail_succeeded` filter

Reported by: johnbillion Owned by: westonruter
Priority: normal Milestone: 6.9.1
Component: Mail Version: 6.9
Severity: normal Keywords: good-first-bug has-patch commit fixed-major dev-reviewed
Cc: Focuses:

Description

In [60698] the documentation for the wp_mail_succeeded filter was updated to include the $embeds element in its $mail_data argument, but this element is not actually included.

The $embeds element should be added to this array.

Attachments (2)

64348.diff​ (469 bytes ) - added by iflairwebtechnologies 10 months ago.
Fixed : The $embeds element issue
64348-docs.diff​ (1.0 KB ) - added by peterwilsoncc 9 months ago.

Download all attachments as: .zip

Change History (16)

@iflairwebtechnologies
10 months ago

Fixed : The $embeds element issue

#1 @iflairwebtechnologies
10 months ago

  • Keywords has-patch added; needs-patch removed

Title:
Fix missing $embeds element in $mail_data for wp_mail_succeeded filter

Description:
This patch resolves a bug where the $embeds element is missing from the $mail_data array when the wp_mail_succeeded filter is applied. Although WordPress documentation for version 6.9 had been updated to reflect the inclusion of the $embeds element in the $mail_data argument, the actual code was not updated, causing the $embeds element to be absent.

#3 @SirLouen
10 months ago

  • Keywords changes-requested added
  • Priority low → normal

Nice catch @johnbillion

It's so weird, I have notifications enabled for this component, but I was not notified when this was opened. I'm going to look into it, and report in meta.

@iflairwebtechnologies check Github.

​@westonruter commented on ​PR #10594:
10 months ago #4

I've sent you a PR to add a fix to this.

The PR: ​https://github.com/iflair/iflair-develop/pull/1

#5 @westonruter
10 months ago

  • Owner set to SirLouen
  • Status new → reviewing

#6 @westonruter
10 months ago

  • Milestone Awaiting Review → 6.9.1

#7 @westonruter
10 months ago

  • Owner changed from SirLouen to westonruter

#8 @SirLouen
10 months ago

  • Keywords commit added; changes-requested removed

#9 @westonruter
10 months ago

  • Resolution → fixed
  • Status reviewing → closed

In 61352:

Mail: Add missing embeds key for the wp_mail_succeeded action's $mail_data param.

Follow-up to [60698].

Props iflairwebtechnologies, SirLouen, johnbillion.
See #28059.
Fixes #64348.

#10 @westonruter
10 months ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Re-opening for 6.9 backport consideration.

@peterwilsoncc
9 months ago

#11 follow-up: @peterwilsoncc
9 months ago

@since annotations for the filter changes were missed during the 6.9.0 cycle. I think it would be good to include those while doing a fast-follow. See 64348-docs.diff​.

#12 in reply to: ↑ 11 @westonruter
9 months ago

Replying to peterwilsoncc:

@since annotations for the filter changes were missed during the 6.9.0 cycle. I think it would be good to include those while doing a fast-follow. See 64348-docs.diff​.

@peterwilsoncc It looks like a superset of this this ended up getting committed by @johnbillion in [61386]?

#13 @peterwilsoncc
9 months ago

  • Keywords dev-reviewed added

@westonruter Ace, thank you @johnbillion!

[61352] is good for merging to the 6.9 branch.

#14 @peterwilsoncc
9 months ago

  • Resolution → fixed
  • Status reopened → closed

In 61393:

Mail: Add missing embeds key for the wp_mail_succeeded action's $mail_data param.

Follow-up to [60698].

Reviewed by peterwilsoncc.
Merges [61352] to the 6.9 branch.

Props iflairwebtechnologies, SirLouen, johnbillion, westonruter.
See #28059.
Fixes #64348.

Note: See TracTickets for help on using tickets.