Image/Page naming collisions

[SpencerLavery]

The ability to change a media file's permalink 'slug' would be awesome. Currently it appears to use the meta data (EXIF?) from the photo and not the 'title' that you input. If it worked off of the 'title' that would be an improvement, but being able to fully customise it would be very handy.

[kjellkk]

I think this should be considered a Bug. Since it actually means that if you have a page with the same slug, it will be "overriden" by media files.

The slug for media files/pages should be treated like other slugs, so that you can not have conflicting slugs.

[kjellkk]

oh - and forgot to say, besides editing the MySql tables directly - deleting the file and re-uploading with a new filename is the only way to fix it if.
That is if I want to have the page with the same slug showing properly.

[kjellkk]

on third thought. This is a bug most definitely, shouldn't the media pages come up as

www.site.com/pagename/attachment/medianame ?

Those links don't work with the RC2 I installed. Ie they exist as without /attachment/ and won't work.

[SpencerLavery]

I wasn't aware that they had a higher priority than page slugs - that does seem odd. They don't seem to slot into the URL Rewrite structure very well at all currently. You're correct in suggesting that they should have their own seperate URL base such as "attachment" - I would personally prefer "media" but I'm sure it should be changeable. I would prefer it as:

www.sitename.com/media/file.jpg

Losing the page/post name from the URL entirely, as with the old-style file uploads (typically "/wp-content/uploads/"). Because we should be able to add a media file to multiple pages and posts and have each media file retain its own orginal permalink for SEO purposes and to keep comments consistent.

An aside- how does the media file's permalink overwrite a Page's permalink with a default permalink structure? Surely the post-name in the media file's permalink shouldn't prevent that?

[SpencerLavery]

Didn't mean to do that.

[janbrasna]

The slug is indeed generated from the uploaded file name, only sanitized.

I think we should be able to generate own slug if needed (as well as set other things like comments/pings_status, see #8177 etc.).

Some other described symptoms are already fixed in 2.7, e.g. the current attachment permalink is:

http://example.com/2000/01/01/post-name/attachment-name/

and shouldn't normally collide with anything (as long as you keep away from using some comment-page- or page- and similar as filenames).

Because we should be able to add a media file to multiple pages and posts and have each media file retain its own orginal permalink for SEO purposes and to keep comments consistent.

If you add the same attachment to multiple posts, it links to the original URL, so there's always only one incarnation of the attachment (as this is the way to collect all the comments under the attachment and to avoid duplicate content).

[anmari]

Replying to kjellkk:

Since it actually means that if you have a page with the same slug, it will be "overriden" by media files.

I think this is exactly what happened to a client of mine. She could edit a sub page, but whenever she viewed it, then media.php came up with what appeared to be images with the slug name in the image somewhere. She could not get her edits to show up. I eventually figured out more or less what was happening and changed the page slug names, since changing the image titles did not seem to make a difference. I wrote the situation up in more detail here: ​http://webdesign.anmari.com/submenu-page-slug-attached-media-confusion/

[truthmedia]

Still experiencing this on WP 2.7.1.

Steps to duplicate:
On a vanilla WP install with the URL rewriting enabled, attach an image called test.jpg to the About page. Then create a sub-page under About called "Test". When attempting to view /about/test/ you will see the image, rather than the "Test" page.

The same problem exists when uploading images directly to WordPress through the media library controls as opposed to attaching an image to a post. In this case, the image parent is set to '0' and the image test.jpg is viewable directly off the root of the site at /test/ and can override existing pages with the same name on the same level.

[Denis-de-Bernardy]

please give the attached patch a shot in the latest trunk

[ryan]

$sql should be $check_sql?

[Denis-de-Bernardy]

very true. updated diff attached.

[Denis-de-Bernardy]

6437.diff uses a slightly different approach. It fixes the potential issue with attachments and pages rather that only pages. And it would allow other hierarchical types added by plugins to be processed as well if needed.

[Denis-de-Bernardy]

See also #9539

[ryan]

(In [11125]) Make post slugs unique across all hierarhical post types. Props Denis-de-Bernardy. fixes #6437