Context Navigation

← Previous Ticket
Next Ticket →

#64426 closed defect (bug) (fixed)

WP_Filesystem_Direct::getchmod() does not handle fileperms() errors

Reported by:	vietcgi	Owned by:	westonruter
Priority:	normal	Milestone:	7.0
Component:	Filesystem API	Version:
Severity:	normal	Keywords:	has-patch has-unit-tests
Cc:		Focuses:

Description

Description:

The getchmod() method in WP_Filesystem_Direct has a documented FIXME:

"FIXME does not handle errors in fileperms()"

When a file doesn't exist, fileperms() returns false, which gets converted to '0' - not a valid permission string.

This PR fixes it by returning false on failure, matching the pattern used by owner() and group() in the same class.

PR: https://github.com/WordPress/wordpress-develop/pull/10637

Change History (5)

This ticket was mentioned in PR #10637 on WordPress/wordpress-develop by vietcgi.

7 months ago #1

Keywords has-patch has-unit-tests added

## Summary

The getchmod() method in WP_Filesystem_Direct had a documented FIXME noting it doesn't handle errors from fileperms().

When a file doesn't exist, fileperms() returns false, which then gets passed to decoct() and returns '0' - not a valid permission string.

This PR adds proper error handling to return false on failure, matching the pattern used by other methods in the class like owner() and group().

## Changes

Return false when fileperms() fails
Update return type to string|false
Update test to verify false is returned for non-existent paths

## Testing

Existing files: returns permissions as before (e.g. '644')
Non-existent files: now returns false instead of '0'
gethchmod() still works correctly (intval(false, 8) equals 0, same as before)