WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6443 closed defect (bug) (fixed)

flash uploader didn't show in IE7, showed script errors

Reported by: tsimmons Owned by:
Milestone: 2.5.1 Priority: high
Severity: critical Version: 2.5
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

When opening the "Add Media" dialog, the flash uploader was absent and instead replaced with the standard "file" input. The reason was due to two script errors that IE didn't like.

Deleting two extra commas in two files fixes the issue. I'm attaching a proposed patch.

Attachments (1)

fileuploaderfix.patch (1.3 KB) - added by tsimmons 6 years ago.
diff for patch

Download all attachments as: .zip

Change History (6)

tsimmons6 years ago

diff for patch

comment:1 Viper007Bond6 years ago

  • Keywords has-patch commit added
  • Priority changed from normal to high
  • Severity changed from normal to blocker

This is one of those bugs that drives me absolutely nuts.

comment:2 thee176 years ago

I too have tried this, and it works for me in IE7 on XP, also tested doesnt break Safari 3 Mac, FF2 Mac, FF2 XP.

comment:3 lloydbudd6 years ago

  • Milestone changed from 2.6 to 2.5.1
  • Severity changed from blocker to critical

comment:4 markjaquith6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7572]) Remove errant commas to prevent file uploader script errors in IE7. props tsimmons. fixes #6443 for trunk

comment:5 markjaquith6 years ago

(In [7573]) Remove errant commas to prevent file uploader script errors in IE7. props tsimmons. fixes #6443 for 2.5.1

Note: See TracTickets for help on using tickets.