WordPress.org
Get WordPress

Make WordPress Core

Opened 4 months ago

Last modified 2 months ago

#64484 new defect (bug)

viewScriptModule is also being loaded in the block editor

Reported by: vrishabhsk's profile vrishabhsk Owned by:
Milestone: 7.1 Priority: normal
Severity: minor Version: 6.9
Component: Editor Keywords: has-patch dev-feedback
Focuses: Cc:

Description

viewScriptModule file defined in the block.json is meant to be loaded only in the frontend when the block is displayed but right now is also being loaded in the block editor.

Additional information : ​https://github.com/WordPress/gutenberg/issues/72833

Change History (6)

This ticket was mentioned in ​PR #10693 on ​WordPress/wordpress-develop by ​@vrishabhsk.
4 months ago #1

  • Keywords has-patch added
  • Added a is_admin check before the viewScriptModule scripts are enqueued via wp_enqueue_script_module

Trac ticket: https://core.trac.wordpress.org/ticket/64484

#2 @westonruter
4 months ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 7.0

Is this not also an issue for ​viewScript?

This ticket was mentioned in ​Slack in #core by juanmaguitar. ​View the logs.
2 months ago

#4 @juanmaguitar
2 months ago

  • Keywords dev-feedback added; reporter-feedback removed

From today's bug scrub

As per @jonsurrell comment on #10693 this needs more exploration by a developer

This really needs some debugging and an explanation. I don't think this change should move ahead until there's an understanding of why these systems behave differently.

I'm removing the reporter-feedback keyboard and adding the dev-feedback keyword.

@jonsurrell and @westonruter, do you think we could clarify this ticket in time for WP 7.0 RC1?

#5 @westonruter
2 months ago

It's unlikely that I'm going to have time to investigate for 7.0.

#6 @juanmaguitar
2 months ago

  • Milestone changed from 7.0 to 7.1

It's unlikely that I'm going to have time to investigate for 7.0.

Punting it then for 7.1

Note: See TracTickets for help on using tickets.