WP_Block_Processor should indicate that inner HTML matches no block type.

[dmsnell]

When the Block Processor was introduced there was a latent bug in the is_block_type() method. It misreports the block types when inner HTML is involved, as it was written before the concepts of inner HTML and top-level freeform content were separated.

It should only report block type matches for actual block delimiters and for top-level freeform content.

Trac ticket: Core-64485

## Status

• [ ] Add unit tests exposing the bug and demonstrating the fix.

## Summary

Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved.

This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built.

[dmsnell]

In 61452:

Block Processor: Fix is_block_type() for inner HTML

Previously, the WP_Block_Processor class was making a mistake in
mis-reporting whether a token matches a block type when #innerHTML spans
are involved.

This patch fixes the logic, which was originally written before a
distinction between inner HTML and top-level freeform content was built.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10701
Discussed in https://core.trac.wordpress.org/ticket/64485

Fixes #64485.

[dmsnell]

Re-opening for review for backport into 6.9.1 branch.

[jorbin]

@jonsurrell @westonruter since both of you worked on the original ticket (#61401) for the Block Processor, would you be able to review this for backport?

[westonruter]

I will defer to Jon since he's much more familiar with this code.

[jonsurrell]

I'm in touch with @dmsnell and we'll get this sorted for 6.9.1.

[jonsurrell]

[61452] looks good to backport to 6.9.

[jorbin]

Adding dev-reviewed based on @jonsurrell's last comment.

Minor, but I do think a PR could be helpful to ensure that tests pass on php7.2 & 7.3 since those aren't being run by trunk

# This is a backport testing PR for [61452].

Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved.

This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10701.
Discussed in https://core.trac.wordpress.org/ticket/64485.

Trac ticket: https://core.trac.wordpress.org/ticket/64485

[wildworks]

@dmsnell @jonsurrell Do you have the bandwidth to commit the changes to the 6.9 branch? The backport tests seem to work fine.

[jonsurrell]

In 61528:

Block Processor: Fix is_block_type() for inner HTML

Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved.

This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10701
Discussed in https://core.trac.wordpress.org/ticket/64485

Reviewed by jonsurrell.
Merges [61452] to the 6.9 branch.

Props dmsnell.
Fixes #64485.

[dmsnell]

thanks doubly @jonsurrell and @wildworks!