Editor: LinkControl dialog missing ARIA labels

[mohammadzaid]

LinkControl dialog (Ctrl+K) lacks proper accessibility:

Issues:

1. Missing role="dialog" on modal container
2. Missing aria-labelledby on dialog
3. URLInput missing aria-label="Link URL"
4. Search input missing aria-label="Search links"

Fix ready: ​https://github.com/Zaidfarooqui01/my-wordpress-pr/compare/fix/good-first-bug-63108

Tested: Chrome Accessibility tab + screen reader

# Gutenberg/WordPress Core: Editor

Add accessibility improvements per Trac #64490:

• Add role="dialog", aria-labelledby="link-dialog-title", and aria-modal="true" to LinkControl modal container
• Add hidden heading id="link-dialog-title" with text "Insert Link"
• Add aria-label="Link URL" to URLInput field
• Add aria-label="Search links" to search input field

Tested: Chrome Accessibility Tree + NVDA screen reader

Fixes #64490

Props: mohammadzaid

See: https://core.trac.wordpress.org/ticket/64490

---

[wildworks]

Hi, @mohammadzaid, thanks for submitting the PR!

Unfortunately, the LinkControl is a React component and is not developed in WordPress core. It's developed in Gutenberg, so you'll need to clone ​the Gutenberg GitHub repository and create a pull request based on it.

However, my understanding is that the LinkControl is just a popover and does not need a dialog role in the first place.

Please let me know if I've missed something.

[mohammadzaid]

@wildworks Thank you for the quick review and clarification!

You're absolutely right - I missed that LinkControl lives in Gutenberg, not Core.

✅ Next steps I will be taking:

1. Closing this Core PR
2. Cloning Gutenberg repo
3. Creating proper PR → ​https://github.com/WordPress/gutenberg/pulls

Quick question: Regarding the dialog role - should LinkControl popover have ARIA labels for screen readers, or is current implementation already accessible?

Thanks for the learning!

[wildworks]

Replying to mohammadzaid:

✅ Next steps I will be taking:

1. Closing this Core PR
2. Cloning Gutenberg repo
3. Creating proper PR → ​https://github.com/WordPress/gutenberg/pulls

Quick question: Regarding the dialog role - should LinkControl popover have ARIA labels for screen readers, or is current implementation already accessible?

I believe the LinkControl component is already accessible, but I think it would be a good idea to submit an issue and get feedback from more people before submitting a PR.

Thanks for the PR!

Unfortunately, this PR isn't acceptable because the LinkControl component is managed at the Gutenberg repo. See https://core.trac.wordpress.org/ticket/64490#comment:2

[mohammadzaid]

Per @wildworks guidance and Gutenberg guidelines:

Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/74505
Gutenberg Issue: ​https://github.com/WordPress/gutenberg/issues/74506

Ported LinkControl ARIA labels from Core PR #10708.

Thanks for the quick direction! 🙏