Make WordPress Core

Opened 5 weeks ago

Closed 2 weeks ago

#64491 closed defect (bug) (fixed)

Update to PHPMailer 7.0.2

Reported by: sirlouen's profile SirLouen Owned by: sirlouen's profile SirLouen
Milestone: 7.0 Priority: normal
Severity: normal Version: 6.9
Component: External Libraries Keywords: has-patch
Focuses: Cc:

Description (last modified by SirLouen)

PHPMailer 7.0.2 last release:
https://github.com/PHPMailer/PHPMailer/releases/tag/v7.0.2

Critical for WP because it brings the Sender address fix to PHPMailer.

Closes #64368

Change History (16)

#1 @SirLouen
5 weeks ago

  • Owner set to SirLouen
  • Status changed from new to assigned

This ticket was mentioned in PR #10709 on WordPress/wordpress-develop by @SirLouen.


5 weeks ago
#2

#3 @SirLouen
5 weeks ago

  • Description modified (diff)

#5 @SergeyBiryukov
5 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 61468:

External Libraries: Upgrade PHPMailer to version 7.0.2.

The latest version:

  • Includes a fix for sendmail parameter problems in WordPress.
  • Reduces memory consumption when sending large attachments.

References:

Follow-up to [54937], [55557], [56484], [57137], [59246], [59481], [60623], [60813], [60888], [61249].

Props SirLouen, robinvandervliet, desrosj, siliconforks, digitalblanket, studiomondiale, jorbin, westonruter, dmsnell, zoe20, Monarobase, amanandhishoe, SergeyBiyrukov.
Fixes #64491. See #64368.

#6 @SergeyBiryukov
5 weeks ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 6.9.1 consideration.

#7 @westonruter
5 weeks ago

  • Keywords dev-feedback added

@dmsnell commented on PR #10713:


5 weeks ago
#8

I didn’t see any explanation for the mode of operation, so I’m basing my question on what it appears to be doing. It appears to try and remove the -f arg out of the sendmail_path and manually set the Sender value.

Why was this approach taken instead of trying to avoid setting ->Sender in PHP when -f is detected?

This ticket was mentioned in Slack in #core by jorbin. View the logs.


4 weeks ago

#10 @jorbin
4 weeks ago

I'm unsure if this is necessary for 6.9.1 if the outcome of #64368 is to revert [61010], especially in light of the unanswered questions on the PR (which came in post commit)

This ticket was mentioned in Slack in #core by wildworks. View the logs.


3 weeks ago

#12 @wildworks
3 weeks ago

I also suggest reverting [61010] in the 6.9 branch and not backporting [61468].

#13 @SirLouen
3 weeks ago

I don't want to keep beating this dead horse but seriously: not bringing this to 6.9.1 is a major error specially if you are reverting [61010]

If this is at least backported, people with the issue could easily test it during 6.9.1 without any affection (as this is an fix ON TOP of the "problem" is not different behaviour).

Whoever is willing to test (I doubt that anyone is willing to test this, but who knows), could easily and manually switch the setFrom in their machines and see the resulting mailing behaviour, but if this patch is not in place, the whole setup for testing is way more complex and I doubt that a single soul will be willing to do it at all.

Last edited 3 weeks ago by SirLouen (previous) (diff)

This ticket was mentioned in Slack in #core by jorbin. View the logs.


3 weeks ago

#15 @jorbin
3 weeks ago

Since wp_mail is pluggable, wouldn't a plugin that is designed to help testing in 6.9.1 be able to include a different version of PHPMailer?

@SergeyBiryukov since you reopened this, what are your thoughts? Do you think this is still necessary in light of the revert of [61010]?

#16 @jorbin
2 weeks ago

  • Keywords fixed-major dev-feedback removed
  • Milestone changed from 6.9.1 to 7.0
  • Resolution set to fixed
  • Status changed from reopened to closed

Based on lack of response, moving this out of the 6.9.1 milestone and closing as this was committed in 7.0

Note: See TracTickets for help on using tickets.