WordPress.org
Get WordPress

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#64515 closed defect (bug) (fixed)

Duplicate @see keyword in PHPDoc for wp_should_load_separate_core_block_assets()

Reported by: marian1 Owned by: westonruter
Priority: normal Milestone: 7.0
Component: Script Loader Version: 6.8
Severity: trivial Keywords: has-patch good-first-bug
Cc: Focuses: docs

Description

The wp_should_load_separate_core_block_assets() function contains a malformed @see tag with the keyword duplicated (@see @see wp_should_load_...() instead of @see wp_should_load_...()).

Change History (5)

#1 @sabernhardt
9 months ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → 7.0
  • Version → 6.8

Good catch. That was part of [59823], and the ​Developer Resources page creates an extra link from it right now.

Would you like to make the patch in script-loader.php, or should I mark this as a good first bug?

This ticket was mentioned in ​PR #10744 on ​WordPress/wordpress-develop by ​@mukesh27.
9 months ago #2

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/64515

#3 @mukesh27
9 months ago

  • Keywords good-first-bug added

I’ve opened a draft PR in case any new contributors would like to review it. If someone prefers to open a similar PR themselves, feel free to close mine.

Happy contributing! 🎉

#4 @showravhasan
9 months ago

Reviewed PR 10744 on GitHub.

The fix correctly removes the duplicate @see tag. LGTM! 👍

Last edited 9 months ago by showravhasan (previous) (diff)

#5 @westonruter
9 months ago

  • Owner set to westonruter
  • Resolution → fixed
  • Status new → closed

In 61496:

Docs: Remove duplicated @see PHPDoc tag.

Follow-up to [59823].

Props marian1, showravhasan, sabernhardt, mukesh27.
See #61965, #64224.
Fixes #64515.

Note: See TracTickets for help on using tickets.