Context Navigation

← Previous Ticket
Next Ticket →

#64526 closed enhancement (fixed)

Twenty Twenty-One: consistently use theme version when enqueueing resources

Reported by:	sabernhardt	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	7.0
Component:	Bundled Theme	Version:
Severity:	minor	Keywords:	has-patch
Cc:		Focuses:

Description

previously mentioned on PR 10493

Twenty Twenty-One uses wp_get_theme()->get( 'Version' ) for most of its styles and scripts, but three dark mode scripts have a string of 1.0.0.

The string could be changed to modified dates, as Twenty Ten through Twenty Seventeen use for their blocks.css and similar files. However, I prefer making the version consistent within the Twenty Twenty-One theme.

Attachments (1)

64526.diff (1.2 KB ) - added by sabernhardt 6 months ago.

Download all attachments as: .zip

Change History (5)

#1 @sabernhardt
6 months ago

In PR 773, all 4 dark mode resources used '1.0.0' as the version string.
[49574] switched the stylesheet to
wp_enqueue_style( 'tt1-dark-mode', $url, array( 'twenty-twenty-one-style' ), wp_get_theme()->get( 'Version' ) ); // @phpstan-ignore-line. Version is always a string.

@sabernhardt
6 months ago

Attachment 64526.diff added

#2 @sabernhardt
6 months ago

Keywords has-patch added

#3 @SergeyBiryukov
6 months ago

Milestone Awaiting Review → 7.0

#4 @SergeyBiryukov
6 months ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 61500:

Twenty Twenty-One: Consistently use theme version when enqueueing resources.

Follow-up to [49478], [49574].

Props sabernhardt.
Fixes #64526.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core