Make WordPress Core

Opened 3 weeks ago

Closed 7 days ago

Last modified 7 days ago

#64530 closed defect (bug) (fixed)

Backport: Paragraph: Add text column support

Reported by: scruffian's profile scruffian Owned by: audrasjb's profile audrasjb
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch has-unit-tests gutenberg-merge commit
Focuses: Cc:

Description

Backport for https://github.com/WordPress/gutenberg/pull/74656/
GitHub PR: https://github.com/WordPress/wordpress-develop/pull/10756

## What?
Enables columns support in paragraph blocks

## Why?
<!-- Why is this PR necessary? What problem is it solving? Reference any existing previous issue(s) or PR(s), but please add a short summary here, too -->
This is a useful control for the paragraph block.

## How?
<!-- How is your PR addressing the issue at hand? What are the implementation details? -->
Add support for textColumns to the block

## Testing Instructions

  1. Select a paragraph block
  2. Enable columns in the paragraph typography block
  3. Confirm that changes to the number of columns are reflected in the frontend and editor

Change History (8)

This ticket was mentioned in PR #10756 on WordPress/wordpress-develop by @scruffian.


3 weeks ago
#1

  • Keywords has-patch has-unit-tests added

#2 @wildworks
3 weeks ago

  • Keywords gutenberg-merge added
  • Milestone changed from Awaiting Review to 7.0

#3 @wildworks
3 weeks ago

  • Keywords commit added

#4 @wildworks
3 weeks ago

Please note that PR 10756 does not actually add textColumns support to the Paragraph block. The PR simply add the block support to appearance tools opt-ins.

#5 @audrasjb
7 days ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Self assigning for final review and commit.

#6 @audrasjb
7 days ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 61570:

Editor: Add textColumn block support to appearance tools opt-ins.

This changeset adds textColumn block support to appearance tools opt-ins.
Backports Gutenberg PR 74656: https://github.com/WordPress/gutenberg/pull/74656/

Props scruffian, wildworks.
Fixes #64530

#7 @audrasjb
7 days ago

In 61571:

Editor: Fix an indentation issue after [61570].

Follow-up to [61570].

See #64530.

#8 @SergeyBiryukov
7 days ago

In 61573:

Tests: Correct unit tests for textColumn block support in appearance tools opt-ins.

Follow-up to [61570].

See #64530.

Note: See TracTickets for help on using tickets.