Make WordPress Core

Opened 4 months ago

Closed 3 months ago

Last modified 2 months ago

#64530 closed defect (bug) (fixed)

Backport: Paragraph: Add text column support

Reported by: scruffian's profile scruffian Owned by: audrasjb's profile audrasjb
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch has-unit-tests gutenberg-merge commit add-to-field-guide needs-dev-note
Focuses: Cc:

Description

Backport for https://github.com/WordPress/gutenberg/pull/74656/
GitHub PR: https://github.com/WordPress/wordpress-develop/pull/10756

## What?
Enables columns support in paragraph blocks

## Why?
<!-- Why is this PR necessary? What problem is it solving? Reference any existing previous issue(s) or PR(s), but please add a short summary here, too -->
This is a useful control for the paragraph block.

## How?
<!-- How is your PR addressing the issue at hand? What are the implementation details? -->
Add support for textColumns to the block

## Testing Instructions

  1. Select a paragraph block
  2. Enable columns in the paragraph typography block
  3. Confirm that changes to the number of columns are reflected in the frontend and editor

Change History (10)

This ticket was mentioned in PR #10756 on WordPress/wordpress-develop by @scruffian.


4 months ago
#1

  • Keywords has-patch has-unit-tests added

#2 @wildworks
4 months ago

  • Keywords gutenberg-merge added
  • Milestone changed from Awaiting Review to 7.0

#3 @wildworks
4 months ago

  • Keywords commit added

#4 @wildworks
4 months ago

Please note that PR 10756 does not actually add textColumns support to the Paragraph block. The PR simply add the block support to appearance tools opt-ins.

#5 @audrasjb
3 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Self assigning for final review and commit.

#6 @audrasjb
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 61570:

Editor: Add textColumn block support to appearance tools opt-ins.

This changeset adds textColumn block support to appearance tools opt-ins.
Backports Gutenberg PR 74656: https://github.com/WordPress/gutenberg/pull/74656/

Props scruffian, wildworks.
Fixes #64530

#7 @audrasjb
3 months ago

In 61571:

Editor: Fix an indentation issue after [61570].

Follow-up to [61570].

See #64530.

#8 @SergeyBiryukov
3 months ago

In 61573:

Tests: Correct unit tests for textColumn block support in appearance tools opt-ins.

Follow-up to [61570].

See #64530.

#9 @audrasjb
2 months ago

  • Keywords add-to-field-guide needs-dev-note added

This is worth mentioning in the Field Guide.
Also adding needs-dev-note just in case we can mention it in a more general note.

#10 @wildworks
2 months ago

A dev note for this feature is being tracked in Gutenberg, and a draft dev note has already been completed.

Note: See TracTickets for help on using tickets.