WordPress.org
Get WordPress

Make WordPress Core

Opened 6 weeks ago

Last modified 3 hours ago

#64584 reviewing defect (bug)

WP_Theme: Unused private method _check_headers_property_has_correct_type()

Reported by: marian1's profile marian1 Owned by: jorbin's profile jorbin
Milestone: 7.0 Priority: normal
Severity: normal Version: 6.4
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

WP_Theme::_check_headers_property_has_correct_type() is a private static method that is defined but not called anywhere. It was introduced in WordPress 6.3.2 and was not used even at the time of introduction. Because the method is private, it cannot be used by plugins or themes, and removing it would not raise backwards-compatibility concerns.

Change History (6)

This ticket was mentioned in ​PR #10839 on ​WordPress/wordpress-develop by ​@marian1.
6 weeks ago #1

  • Keywords has-patch added

…rrect_type()

Trac ticket: https://core.trac.wordpress.org/ticket/64584

​@mukesh27 commented on ​PR #10839:
6 weeks ago #2

This was introduced in Changeset 56835 / ​https://github.com/WordPress/wordpress-develop/commit/ed821528ee82a71078a491dfdbc30dfc8f7d7170 by @aaronjorbin.

Aaron, do you know the reason this was added? Also, would it make sense to remove it if it’s no longer needed? It looks like the function is also missing documentation.

#3 @mukesh27
6 weeks ago

  • Milestone changed from Awaiting Review to 7.0

Moving into milestone for visibility.

#4 @westonruter
6 weeks ago

  • Owner set to jorbin
  • Status changed from new to reviewing
  • Version set to 6.4

This ticket was mentioned in ​Slack in #core by juanmaguitar. ​View the logs.
3 hours ago

#6 @juanmaguitar
3 hours ago

From today's bug scrub

The related PR #10839 is approved. I think it just needs a final review by the owner (@jorbin) to close it. I'll ping him about it.

@jorbin The PR has been approved. Do you think we'll be able to close this ticket in time for WP 7.0 RC1 (in ~1 week)?

Note: See TracTickets for help on using tickets.