Make WordPress Core

Opened 7 months ago

Closed 5 months ago

#64584 closed defect (bug) (fixed)

WP_Theme: Unused private method _check_headers_property_has_correct_type()

Reported by: marian1 Owned by: jorbin
Priority: normal Milestone: 7.0
Component: Themes Version: 6.4
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

WP_Theme::_check_headers_property_has_correct_type() is a private static method that is defined but not called anywhere. It was introduced in WordPress 6.3.2 and was not used even at the time of introduction. Because the method is private, it cannot be used by plugins or themes, and removing it would not raise backwards-compatibility concerns.

Change History (9)

This ticket was mentioned in PR #10839 on WordPress/wordpress-develop by @marian1.


7 months ago
#1

  • Keywords has-patch added

…rrect_type()

Trac ticket: https://core.trac.wordpress.org/ticket/64584

@mukesh27 commented on PR #10839:


7 months ago
#2

This was introduced in Changeset 56835 / https://github.com/WordPress/wordpress-develop/commit/ed821528ee82a71078a491dfdbc30dfc8f7d7170 by @aaronjorbin.

Aaron, do you know the reason this was added? Also, would it make sense to remove it if it’s no longer needed? It looks like the function is also missing documentation.

#3 @mukesh27
7 months ago

  • Milestone Awaiting Review7.0

Moving into milestone for visibility.

#4 @westonruter
7 months ago

  • Owner set to jorbin
  • Status newreviewing
  • Version6.4

This ticket was mentioned in Slack in #core by juanmaguitar. View the logs.


5 months ago

#6 @juanmaguitar
5 months ago

From today's bug scrub

The related PR #10839 is approved. I think it just needs a final review by the owner (@jorbin) to close it. I'll ping him about it.

@jorbin The PR has been approved. Do you think we'll be able to close this ticket in time for WP 7.0 RC1 (in ~1 week)?

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 months ago

#8 @audrasjb
5 months ago

  • Keywords commit added

#9 @audrasjb
5 months ago

  • Resolutionfixed
  • Status reviewingclosed

In 62065:

Themes: Remove unused private method WP_Theme::_check_headers_property_has_correct_type().

Follow-up to [56835].

Props marian1, mukesh27.
Fixes #64584.

Note: See TracTickets for help on using tickets.