Make WordPress Core

Opened 6 weeks ago

Last modified 8 days ago

#64589 reopened enhancement

Navigation overlay: backport patterns and template part definition

Reported by: onemaggie's profile onemaggie Owned by: scruffian's profile scruffian
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch gutenberg-merge
Focuses: Cc:

Description

This PR backports core PHP changes from Gutenberg (https://github.com/WordPress/gutenberg/pull/74968) that remove the overlay experiment and migrate navigation overlay patterns to use the core namespace.

This backport includes the following core changes:

  • Navigation Pattern Category: Adds the navigation block pattern category registration in block-patterns.php.
  • Navigation Overlay Patterns: Adds five new navigation overlay block patterns.
  • Template Part Area Constant: Adds the WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAY constant and corresponding area definition in block-template-utils.php to support navigation overlay template parts.

This backport is based on changes from WordPress/gutenberg#74968
Testing

  • Verify navigation pattern category appears in the block pattern inserter
  • Verify all five navigation overlay patterns are available and render correctly
  • Verify navigation overlay template parts can be created and used
  • Test pattern insertion in the site editor

Change History (11)

This ticket was mentioned in PR #10844 on WordPress/wordpress-develop by @onemaggie.


6 weeks ago
#1

  • Keywords has-patch added

This PR backports core PHP changes from Gutenberg that remove the overlay experiment and migrate navigation overlay patterns to use the core namespace.

This backport includes the following core changes:

  1. Navigation Pattern Category: Adds the navigation block pattern category registration in block-patterns.php.
  1. Navigation Overlay Patterns: Adds five new navigation overlay block patterns.
  1. Template Part Area Constant: Adds the WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAY constant and corresponding area definition in block-template-utils.php to support navigation overlay template parts.

This backport is based on changes from https://github.com/WordPress/gutenberg/pull/74968

## Testing

  • Verify navigation pattern category appears in the block pattern inserter
  • Verify all five navigation overlay patterns are available and render correctly
  • Verify navigation overlay template parts can be created and used
  • Test pattern insertion in the site editor

Trac ticket: https://core.trac.wordpress.org/ticket/64589

#2 @wildworks
6 weeks ago

  • Keywords gutenberg-merge added

@get_dave commented on PR #10844:


5 weeks ago
#3

Rebase and then we should be good to land 🙏

#4 @scruffian
5 weeks ago

  • Owner set to scruffian
  • Resolution set to fixed
  • Status changed from new to closed

In 61609:

Editor: Navigation overlay - patterns and template part definition.

Adds a new template part for the Navigation block called WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAY, corresponding area definition in block-template-utils.php to support navigation overlay template parts.

Also adds the navigation block pattern category registration in block-patterns.php and five new navigation overlay block patterns.

Reviewed by mikachan, get_dave.

Props onemaggie, scruffian, get_dave, mikachan, wildworks.
Fixes #64589.

#5 @sabernhardt
3 weeks ago

  • Milestone changed from Awaiting Review to 7.0

This ticket was mentioned in PR #11039 on WordPress/wordpress-develop by @wildworks.


3 weeks ago
#6

Trac ticket: https://core.trac.wordpress.org/ticket/64589

## Use of AI Tools

No AI tools were used in this PR.

#8 @wildworks
3 weeks ago

In 61734:

Editor: Update Navigation Overlay template part description.

Refines the Navigation Overlay template description to remove the "full-screen" assumption and clarify that the overlay can be toggled open and closed.

Follow-up to [61609].

Props get_dave, scruffian, wildworks.
See #64589.

@wildworks commented on PR #11039:


3 weeks ago
#9

This PR was committed in [61734]

#10 @wildworks
8 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

One pattern is broken, and another pattern doesn't reflect upstream updates and needs to be fixed.

This ticket was mentioned in PR #11197 on WordPress/wordpress-develop by @wildworks.


8 days ago
#11

Trac ticket: https://core.trac.wordpress.org/ticket/64589

Follow-up to https://core.trac.wordpress.org/changeset/61609

## Use of AI Tools

None

## Description

This PR fixes the following two invalid patterns:

  • Overlay with site info and CTA: The block is broken because one } is missing.
  • Navigation Overlay: This pattern doesn't have an explicit link color, which makes the text invisible in dark themes. This was fixed in Gutenberg (https://github.com/WordPress/gutenberg/pull/74979) but not yet backported to core.
Note: See TracTickets for help on using tickets.