Opened 6 weeks ago
Last modified 8 days ago
#64589 reopened enhancement
Navigation overlay: backport patterns and template part definition
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | General | Keywords: | has-patch gutenberg-merge |
| Focuses: | Cc: |
Description
This PR backports core PHP changes from Gutenberg (https://github.com/WordPress/gutenberg/pull/74968) that remove the overlay experiment and migrate navigation overlay patterns to use the core namespace.
This backport includes the following core changes:
- Navigation Pattern Category: Adds the navigation block pattern category registration in block-patterns.php.
- Navigation Overlay Patterns: Adds five new navigation overlay block patterns.
- Template Part Area Constant: Adds the WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAY constant and corresponding area definition in block-template-utils.php to support navigation overlay template parts.
This backport is based on changes from WordPress/gutenberg#74968
Testing
- Verify navigation pattern category appears in the block pattern inserter
- Verify all five navigation overlay patterns are available and render correctly
- Verify navigation overlay template parts can be created and used
- Test pattern insertion in the site editor
Change History (11)
This ticket was mentioned in PR #10844 on WordPress/wordpress-develop by @onemaggie.
6 weeks ago
#1
- Keywords has-patch added
@get_dave commented on PR #10844:
5 weeks ago
#3
Rebase and then we should be good to land 🙏
#4
@
5 weeks ago
- Owner set to scruffian
- Resolution set to fixed
- Status changed from new to closed
In 61609:
This ticket was mentioned in PR #11039 on WordPress/wordpress-develop by @wildworks.
3 weeks ago
#6
Trac ticket: https://core.trac.wordpress.org/ticket/64589
## Use of AI Tools
No AI tools were used in this PR.
#7
@
3 weeks ago
Based on this feedback in Gutenberg, I submitted a PR to improve the area description.
@wildworks commented on PR #11039:
3 weeks ago
#9
This PR was committed in [61734]
#10
@
8 days ago
- Resolution fixed deleted
- Status changed from closed to reopened
One pattern is broken, and another pattern doesn't reflect upstream updates and needs to be fixed.
This ticket was mentioned in PR #11197 on WordPress/wordpress-develop by @wildworks.
8 days ago
#11
Trac ticket: https://core.trac.wordpress.org/ticket/64589
Follow-up to https://core.trac.wordpress.org/changeset/61609
## Use of AI Tools
None
## Description
This PR fixes the following two invalid patterns:
- Overlay with site info and CTA: The block is broken because one
}is missing. - Navigation Overlay: This pattern doesn't have an explicit link color, which makes the text invisible in dark themes. This was fixed in Gutenberg (https://github.com/WordPress/gutenberg/pull/74979) but not yet backported to core.
This PR backports core PHP changes from Gutenberg that remove the overlay experiment and migrate navigation overlay patterns to use the core namespace.
This backport includes the following core changes:
navigationblock pattern category registration inblock-patterns.php.WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAYconstant and corresponding area definition inblock-template-utils.phpto support navigation overlay template parts.This backport is based on changes from https://github.com/WordPress/gutenberg/pull/74968
## Testing
Trac ticket: https://core.trac.wordpress.org/ticket/64589