![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 5 months ago
Closed 3 months ago
#64589 closed enhancement (fixed)
Navigation overlay: backport patterns and template part definition
| Reported by: | onemaggie | Owned by: | scruffian |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.0 |
| Component: | General | Version: | 7.0 |
| Severity: | normal | Keywords: | has-patch gutenberg-merge |
| Cc: | Focuses: |
Description
This PR backports core PHP changes from Gutenberg (https://github.com/WordPress/gutenberg/pull/74968) that remove the overlay experiment and migrate navigation overlay patterns to use the core namespace.
This backport includes the following core changes:
- Navigation Pattern Category: Adds the navigation block pattern category registration in block-patterns.php.
- Navigation Overlay Patterns: Adds five new navigation overlay block patterns.
- Template Part Area Constant: Adds the WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAY constant and corresponding area definition in block-template-utils.php to support navigation overlay template parts.
This backport is based on changes from WordPress/gutenberg#74968
Testing
- Verify navigation pattern category appears in the block pattern inserter
- Verify all five navigation overlay patterns are available and render correctly
- Verify navigation overlay template parts can be created and used
- Test pattern insertion in the site editor
Change History (23)
This ticket was mentioned in PR #10844 on WordPress/wordpress-develop by @onemaggie.
5 months ago
#1
- Keywords has-patch added
@get_dave commented on PR #10844:
5 months ago
#3
Rebase and then we should be good to land 🙏
This ticket was mentioned in PR #11039 on WordPress/wordpress-develop by @wildworks.
5 months ago
#6
Trac ticket: https://core.trac.wordpress.org/ticket/64589
## Use of AI Tools
No AI tools were used in this PR.
#7
@
5 months ago
Based on this feedback in Gutenberg, I submitted a PR to improve the area description.
@wildworks commented on PR #11039:
5 months ago
#9
This PR was committed in [61734]
#10
@
4 months ago
- Resolution fixed
- Status closed → reopened
One pattern is broken, and another pattern doesn't reflect upstream updates and needs to be fixed.
This ticket was mentioned in PR #11197 on WordPress/wordpress-develop by @wildworks.
4 months ago
#11
Trac ticket: https://core.trac.wordpress.org/ticket/64589
Follow-up to https://core.trac.wordpress.org/changeset/61609
## Use of AI Tools
None
## Description
This PR fixes the following two invalid patterns:
- Overlay with site info and CTA: The block is broken because one
}is missing. - Navigation Overlay: This pattern doesn't have an explicit link color, which makes the text invisible in dark themes. This was fixed in Gutenberg (https://github.com/WordPress/gutenberg/pull/74979) but not yet backported to core.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
4 months ago
#14
@
4 months ago
I believe https://github.com/WordPress/wordpress-develop/pull/11197 should be included in the 7.0 release because it fixes a broken navigation overlay pattern.
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.
4 months ago
@wildworks commented on PR #11197:
4 months ago
#16
Thanks for the review!
@wildworks commented on PR #11197:
4 months ago
#18
This PR was committed by r62114.
#19
@
4 months ago
@wildworks Just a reminder that now that we're in RC, all commits to core should have a 2nd committer review, and the Reviewed by handle. line should appear in the commit message. See https://wordpress.slack.com/archives/C18723MQ8/p1774409572518559
I can see that this was reviewed by multiple committers in the PR, but there is a formal process in trac tickets for ensuring that trail is tracked here, using the dev-feedback and dev-reviewed keywords. Thanks!
#20
@
4 months ago
@joedolson Thank you for teaching me! I thought double sign-off wasn't necessary because the 7.0 branch hadn't been created yet, but I was mistaken.
This PR backports core PHP changes from Gutenberg that remove the overlay experiment and migrate navigation overlay patterns to use the core namespace.
This backport includes the following core changes:
navigationblock pattern category registration inblock-patterns.php.WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAYconstant and corresponding area definition inblock-template-utils.phpto support navigation overlay template parts.This backport is based on changes from https://github.com/WordPress/gutenberg/pull/74968
## Testing
Trac ticket: https://core.trac.wordpress.org/ticket/64589