Theme updated message shown in wrong context

[Ov3rfly]

When updating a theme and switching to other theme details during update, the updated message is shown in context of current visible other theme details after update in background is finished.

[Presskopp]

As you can see in the screenshots, the update message appears twice. I think it's best to remove these messages completely when you leave the screen of the triggering plugin.

[Presskopp]

it can even appear 3 times, see video

[Ov3rfly]

Took a look at some code.

wp.updates.updateThemeSuccess() in wp-admin/js/updates.js at about line 1600 tries to figure out the selector of target element for the update message.

It uses $notice = $( '.theme-info .notice' ) and obviously gets the element(s) in currently shown context, no matter if or which theme details currently are shown.

The actually updated theme slug would be available in response.slug but the DOM of theme details appears to not have the slug anywhere - or maybe I missed it.

So the suggested fix would be:

• add theme slug to DOM of each theme details
• use response.slug to find target element for the update message
• make sure only one .theme-info .notice is in theme details or use more specific selector to avoid showing message multiple times

[poena]

Duplicate of #41341.

Hi
This is a duplicate of https://core.trac.wordpress.org/ticket/41341 so I am closing this ticket.