Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#64632 closed defect (bug) (fixed)

Remove outdated GitHub reference in custom-html-widgets.js comment

Reported by: mayur8991's profile mayur8991 Owned by: westonruter's profile westonruter
Milestone: 7.0 Priority: normal
Severity: trivial Version: 4.9
Component: Widgets Keywords:
Focuses: Cc:

Description (last modified by sabernhardt)

In wp-admin/js/widgets/custom-html-widgets.js (around line 336),
there is a comment referencing the following URL:

https://github.com/xwp/wordpress-develop/pull/247/commits/5322387d

The link currently returns a 404 error and appears to reference a
non-official fork of WordPress.

Since the link is no longer accessible and does not provide useful
context, it may cause confusion for developers reviewing the code.

It would be good to remove the outdated URL from the comment to
improve code clarity and maintainability.

Change History (5)

#1 @sabernhardt
2 months ago

  • Description modified (diff)
  • Version changed from 6.9.1 to 4.9

Line 336 was part of [41376].

The Wayback archive points to #41596 (which leads to 41596.1.diff and [41260]).

cc: @westonruter

#2 @westonruter
2 months ago

  • Milestone changed from Awaiting Review to 7.0
  • Owner set to westonruter
  • Status changed from new to accepted

#3 @westonruter
2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61627:

Docs: Update broken link in core merge comment.

Follow-up to [41376], [41260].

Props mayur8991, sabernhardt, westonruter.
Fixes #64632.

#4 follow-up: @westonruter
2 months ago

  • Keywords needs-patch removed

@sabernhardt Thank you for digging up the historical context for that. I was tempted to go ahead and remove the wp.customize condition per the comment, but it has been so many years that I don't feel confident to make the change without immersing myself again. And given that the Customizer is now suppressed, as well as these classic widgets, it seems best to leave them be.

#5 in reply to: ↑ 4 @sabernhardt
2 months ago

I was tempted to go ahead and remove the wp.customize condition per the comment, but it has been so many years that I don't feel confident to make the change without immersing myself again. And given that the Customizer is now suppressed, as well as these classic widgets, it seems best to leave them be.

Good idea.

Note: See TracTickets for help on using tickets.